forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Lehmkühler (JIRA) <j...@apache.org>
Subject [jira] Commented: (FOR-211) whole-site html and pdf: broken ext links
Date Thu, 28 Aug 2008 08:33:44 GMT

    [ https://issues.apache.org/jira/browse/FOR-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626487#action_12626487
] 

Andreas Lehmkühler commented on FOR-211:
----------------------------------------

The main problem was an issue in "doc-to-doc-uniqueids.xsl". For aggregated content it tries
to make all links unique by adding a trailing "#". But some of them where added where it don't
have to be.

For example in samples-c/index.xml

"site:docs-samples2/i18n" became "#site:docs-samples1/sample" which is obviously wrong.

It has to be translated to "samples-b/sample.html" and with the trailing "#" it becomes "#samples-b/sample.html"

I have to fix/complete the matching templates starting at line 27. There are 4 cases:

1.) (sub)section-ids
these have to be completed by the ancestor ids (works well without my patch)

2.) #fragment-id references
these have to be completed by the ancestor ids (works well without my patch)

3.) all links using a special protocol as http:,https:,site:,ext: and lm:
they have have to left unchanged because they are translated elsewhere. (without my patch
it only works for http: and https:)

4.) the remaining links. This have to be direct coded links which are relative to the document
in which they are included
these links have to be completed with the whole path, so that they are relative the the site
and not to the document in which they are included (my patch added this behaviour, so that
direct coded links will work within an aggregation)

I hope this was the explanation you're looking for.

As the main problem is solved, I suggest to close this issue. I guess the locationmap-issue
lies perhaps somewhere else, because it already doesn't work in a fresh seeded site without
aggregation. 

> whole-site html and pdf: broken ext links
> -----------------------------------------
>
>                 Key: FOR-211
>                 URL: https://issues.apache.org/jira/browse/FOR-211
>             Project: Forrest
>          Issue Type: Bug
>          Components: Core operations
>    Affects Versions: 0.6
>            Reporter: David Crossley
>            Assignee: Johannes Schaefer
>             Fix For: 0.9-dev
>
>         Attachments: links-HEAD.txt, links-patched.txt, wholesite_pdftab_patch.txt, wholesite_pdftab_patch2.txt,
wholesite_pdftab_patch3.txt
>
>
> In the the generated site.html all of the external links are broken (i.e. the href attributes
are like ... error:#ext:forrest).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message