forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <>
Subject RE: Addressing FOR-652 CSS cleanup (was Re: [jira] Subscription: FOR-open-with-patch)
Date Tue, 22 Apr 2008 09:32:17 GMT
On Mon, 2008-04-21 at 00:19 +0200, Sina K. Heshmati wrote:
> Thorsten's comment on the issue is already helpful: "The task involved are:
> 1) reduce css files (merge the files)
> 2) rename css elements and the corresponding structurer hooks/contracts."
> It would be handy if Gavin and Thorsten shared how they would start so as to divide the
problem into a few subproblems.

I would start with reducing all files in one big one. Afterward we can
decide which elements should get extracted into another css file. 

Your attachment has
<div id="leftbar"> 
  <div id="nav-section">
    <li id="menu_selected_1.1Title" class="pagegroupselected">
     <ul id="menu_selected_1.1" class="selectedmenuitemgroup">
       <li class="menupage">
        <div class="menupagetitle"/> <!-- Current page; no link -->
       <li class="menuitem">
     </ul> <!--/menu_selected_1.1-->
    </li> <!--/menu_selected_1.1Title-->
    <li id="menu_1.2Title" class="pagegroup">

This is way too verbose and should go away in a new version. IMO the @id
does not provide any valuable information therefore it should be
striped. If the @id is needed for the expanding js menu is needed then
the menu should be rewritten.

The id="leftbar" should be renamed to something more general. 

Otherwise looks good to me.

Thorsten Scherler                       
Open Source Java                      consulting, training and solutions

View raw message