Return-Path: 
 <dev-return-28955-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 99175 invoked from network); 2 Mar 2008 01:51:42 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 2 Mar 2008 01:51:42 -0000
Received: (qmail 338 invoked by uid 500); 2 Mar 2008 01:51:38 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 289 invoked by uid 500); 2 Mar 2008 01:51:38 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
List-Post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
List-Id: <dev.forrest.apache.org>
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 278 invoked by uid 99); 2 Mar 2008 01:51:38 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Mar 2008 17:51:38 -0800
X-ASF-Spam-Status: No, hits=1.2 required=10.0
	tests=SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Received: from [66.111.4.27] (HELO out3.smtp.messagingengine.com)
 (66.111.4.27)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 02 Mar 2008 01:51:02 +0000
Received: from compute2.internal (compute2.internal [10.202.2.42])
	by out1.messagingengine.com (Postfix) with ESMTP id 60D8FA7146
	for <dev@forrest.apache.org>; Sat,  1 Mar 2008 20:51:11 -0500 (EST)
Received: from heartbeat2.messagingengine.com ([10.202.2.161])
  by compute2.internal (MEProxy); Sat, 01 Mar 2008 20:51:11 -0500
X-Sasl-enc: 2m8NKvM/ZmSHEIUXucAi/OBekUoQNan+3u1xDdvYQHuL 1204422668
Received: from localhost
 (125.242.221.203.dial.dynamic.acc02-aubu-gou.comindico.com.au
 [203.221.242.125])
	by mail.messagingengine.com (Postfix) with ESMTPSA id 938EB2BA6F
	for <dev@forrest.apache.org>; Sat,  1 Mar 2008 20:51:08 -0500 (EST)
Date: Sun, 2 Mar 2008 12:51:03 +1100
From: David Crossley <crossley@apache.org>
To: dev@forrest.apache.org
Subject: Re: [jira] Updated: (FOR-1072) [PATCH] Bugfixes and improvements for
 PDF output plugin
Message-ID: <20080302015103.GM20469@igg.indexgeo.com.au>
References: <74245951.1204407891075.JavaMail.jira@brutus>
 <47C9C5C2.5090009@apache.org> <20080302001846.GL20469@igg.indexgeo.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080302001846.GL20469@igg.indexgeo.com.au>
User-Agent: Mutt/1.4.2.2i
X-Virus-Checked: Checked by ClamAV on apache.org

David Crossley wrote:
> Ferdinand Soethe wrote:
> > >X [0]                                     samples-b/sample.pdf  BROKEN: 
> > >Error(Unknown location): fo:table-header is missing child elements.
> > >Required Content Model: marker* (table-row+|table-cell+)
> 
> I tested it on our site-author docs which have many more docs
> with tables. It does not report errors for all docs that contain
> tables, e.g. content/xdocs/docs_0_90/linking.xml is okay.
> I supsect perhaps "table captions". Need more investigation.

No, the captions are okay.

I found the problem by comparing documents that failed
with all docs in site-author that contain tables.

We have some sources that have tables with no <tr><th>...</tr> header row.
I added a hack with r632692 to handle that. Can someone do better xsl?

The other failure case is because we have some tables with
a <th> on every row, e.g. docs_0_90/sitemap-ref.xml
See line 453 in resources/stylesheets/helper-commonElements.xsl r632692
which does not handle it. Can someone help with that?

-David