Return-Path: Delivered-To: apmail-forrest-dev-archive@www.apache.org Received: (qmail 41086 invoked from network); 14 Feb 2008 07:37:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Feb 2008 07:37:19 -0000 Received: (qmail 50427 invoked by uid 500); 14 Feb 2008 07:37:13 -0000 Delivered-To: apmail-forrest-dev-archive@forrest.apache.org Received: (qmail 50370 invoked by uid 500); 14 Feb 2008 07:37:13 -0000 Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@forrest.apache.org List-Id: Delivered-To: mailing list dev@forrest.apache.org Received: (qmail 50359 invoked by uid 99); 14 Feb 2008 07:37:13 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Feb 2008 23:37:13 -0800 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_HELO_PASS,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [80.67.18.15] (HELO smtprelay03.ispgateway.de) (80.67.18.15) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Feb 2008 07:36:28 +0000 Received: from p548ff72f.dip.t-dialin.net ([84.143.247.47] helo=[127.0.0.1]) by smtprelay03.ispgateway.de with esmtpa (Exim 4.68) (envelope-from ) id 1JPYeF-0000vP-Sw for dev@forrest.apache.org; Thu, 14 Feb 2008 08:36:48 +0100 Message-ID: <47B3EF8B.4050705@apache.org> Date: Thu, 14 Feb 2008 08:36:43 +0100 From: Ferdinand Soethe User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: dev@forrest.apache.org Subject: Re: svn commit: r627063 - /forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl References: <20080212195235.AFD3F1A9832@eris.apache.org> <1202939227.24492.47.camel@cartman> In-Reply-To: <1202939227.24492.47.camel@cartman> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Df-Sender: 246568 X-Virus-Checked: Checked by ClamAV on apache.org Thorsten Scherler wrote: > On Tue, 2008-02-12 at 19:52 +0000, ferdinand@apache.org wrote: > > Author: ferdinand > > Date: Tue Feb 12 11:52:32 2008 > > New Revision: 627063 > > > > URL: http://svn.apache.org/viewvc?rev=627063&view=rev > > Log: > > Fixed problems of id-attributes not being copied in all > elements and missing for reference. > > > > Modified: > > > forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl > > > > Modified: > forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl > > URL: > http://svn.apache.org/viewvc/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl?rev=627063&r1=627062&r2=627063&view=diff > > > ============================================================================== > > --- > forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl > (original) > > +++ > forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl > Tue Feb 12 11:52:32 2008 > > @@ -468,6 +468,7 @@ > > > match="notice"> > > > + id="{@id}" > > The ugly side effect is that if no @id is present the > above results in > > > To prevent this you could do: > > > > > You do it later on in this commit: > ... > > @@ -1000,16 +1011,10 @@ > > match="figure|img"> > > > text-align="center"> > > + > > > name="insertPageBreaks" /> > > - > - test="normalize-space(@id)!=''"> > > - > - name="id"> > > - > - select="@id" /> > > - > > - > > + > > > > I can remember that having empty @id had caused me some > trouble in the > past. > > salu2 Thanks Thorsten, I will fix that. Best regards, Ferdinand Soethe