forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ferdinand Soethe <ferdin...@apache.org>
Subject Re: svn commit: r627063 - /forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Date Thu, 14 Feb 2008 07:36:43 GMT
Thorsten Scherler wrote:
> On Tue, 2008-02-12 at 19:52 +0000, ferdinand@apache.org wrote:
> > Author: ferdinand
> > Date: Tue Feb 12 11:52:32 2008
> > New Revision: 627063
> >
> > URL: http://svn.apache.org/viewvc?rev=627063&view=rev
> > Log:
> > Fixed problems of id-attributes not being copied in all 
> elements and missing for reference.
> >
> > Modified:
> >     
> forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
> >
> > Modified: 
> forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
> > URL: 
> http://svn.apache.org/viewvc/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl?rev=627063&r1=627062&r2=627063&view=diff
> > 
> ==============================================================================
> > --- 
> forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl

> (original)
> > +++ 
> forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl

> Tue Feb 12 11:52:32 2008
> > @@ -468,6 +468,7 @@
> >      <xsl:template
> >          match="notice">
> >          <fo:block
> > +            id="{@id}"
>
> The ugly side effect is that if no @id is present the 
> above results in
> <fo:block id="">
>
> To prevent this you could do:
> <fo:block>
> <xsl:copy-of select="@id"/>
>
>
> You do it later on in this commit:
> ...
> > @@ -1000,16 +1011,10 @@
> >          match="figure|img">
> >          <fo:block
> >              text-align="center">
> > +            
> >              <xsl:call-template
> >                  name="insertPageBreaks" />
> > -            <xsl:if
> > -                test="normalize-space(@id)!=''">
> > -                <xsl:attribute
> > -                    name="id">
> > -                    <xsl:value-of
> > -                        select="@id" />
> > -                </xsl:attribute>
> > -            </xsl:if>
> > +            <xsl:copy-of select="@id"/>
> >              <!-- Make relative paths absolute -->
>
> I can remember that having empty @id had caused me some 
> trouble in the
> past.
>
> salu2
Thanks Thorsten, I will fix that.

Best regards,
Ferdinand Soethe

Mime
View raw message