forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thors...@apache.org>
Subject Re: svn commit: r628164 - /forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Date Fri, 15 Feb 2008 23:42:45 GMT
On Fri, 2008-02-15 at 21:31 +0100, Ferdinand Soethe wrote:
> After some more testing I found that most of the broken 
> image problems are not new but never showed because old FOP 
> did not report them.

Yes I think so as well, having tested on the old fop.

> 
> Running our current test sites with Forrest 0.8 I found many 
> of the same images missing in the pdf that are reported to 
> be missing now.
> 
> The fix at least solves the problem in committed.xml. Why it 
> does is completely beyond me.

jeje, like Jeremias explains the new fop is able to resolve special
protocols like cocoon:// (I tested on the old one and it does not work
there). This solves the problem I guess for most if not all image links
since we can use cocoon pipelines to generate the image. 

The old way always expected a physical URI (file or http) the new fop
"URIResolver in the FOP-NG block delegates to Cocoon's SourceResolver
framework", meaning the image can be the result of a pipeline.

> 
> Best regards,
> Ferdinand Soethe
> 
> ferdinand@apache.org wrote:
> > Author: ferdinand
> > Date: Fri Feb 15 12:29:05 2008
> > New Revision: 628164
> > 
> > URL: http://svn.apache.org/viewvc?rev=628164&view=rev
> > Log:
> > Changed image handling to solve problems with generated images and fop. Some improvement
but not a complete solution.
> > 

Which are the images that fail, because this should actually fix all
images? If not that can mean that we have another piece of code that is
changing the image linking (or the when test are matching).

> > Modified:
> >     forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
> > 
> > Modified: forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
> > URL: http://svn.apache.org/viewvc/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl?rev=628164&r1=628163&r2=628164&view=diff
> > ==============================================================================
> > --- forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
(original)
> > +++ forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/resources/stylesheets/document-to-fo.xsl
Fri Feb 15 12:29:05 2008
> > @@ -1069,8 +1069,8 @@
> >            </xsl:when>
> >  <!-- relative to document -->
> >            <xsl:otherwise>
> > -            <xsl:value-of
> > -                            select="concat($xmlbasedir,@src)" />
> > +              cocoon://<xsl:value-of
> > +                  select="@src" />
> >            </xsl:otherwise>
> >          </xsl:choose>
> >        </xsl:variable>

Thanks Ferdinand.

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Mime
View raw message