forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thors...@apache.org>
Subject Decouple fo from skinconf (was Re: svn commit: r618400 )
Date Mon, 04 Feb 2008 23:30:05 GMT
On Mon, 2008-02-04 at 19:47 +0000, ferdinand@apache.org wrote:
> Author: ferdinand
> Date: Mon Feb  4 11:47:26 2008
> New Revision: 618400
> 
> URL: http://svn.apache.org/viewvc?rev=618400&view=rev
> Log:
> changes to xmap, pipeline copied from sitemap and adjusted 
> 
> Modified:
>     forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/output.xmap
> 
> Modified: forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/output.xmap
> URL: http://svn.apache.org/viewvc/forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/output.xmap?rev=618400&r1=618399&r2=618400&view=diff
> ==============================================================================
> --- forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/output.xmap
(original)
> +++ forrest/branches/UpdateFOPto094/plugins/org.apache.forrest.plugin.output.pdf/output.xmap
Mon Feb  4 11:47:26 2008
> @@ -34,7 +34,17 @@
>              <map:serialize type="fo2pdf"/>
>            </map:when>
>            <map:otherwise>
> -            <map:generate src="cocoon://{1}{2}.fo"/>
> +              <map:aggregate element="site">
> +                  <map:part src="cocoon:/skinconf.xml"/>
> +                  <map:part src="cocoon:/{1}{2}.xml"/>

Side note: both matches need to read: cocoon://

> +              </map:aggregate>
> +              <!-- <map:transform type="idgen"/> -->
> +              <map:transform type="xinclude"/>
> +              <map:transform type="linkrewriter" src="cocoon://{1}linkmap-{2}.fo"/>
> +              <map:transform src="{lm:pdf.transform.document.fo}">
> +                  <map:parameter name="imagesdir" value="{properties:resources.images}/"/>
> +                  <map:parameter name="xmlbasedir" value="{properties:content.xdocs}{1}"/>
> +              </map:transform>
>              <map:serialize type="fo2pdf"/>
>            </map:otherwise>
>          </map:select>

IMO the fo plugin should not have a dependency on skinconf. The
dispatcher do not use skinconf but would need to maintain one if we have
such a dependency. 

The fop plugin could use the properties to get the configuration values.
https://svn.apache.org/repos/asf/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/internal.xmap
<!--FOR-808 WORKAROUND
      Creating a virtual skinconf from the properties module.
      The core depends on a skinconf but the dispatcher not.
      See as well FOR-829 where we use this config.-->
    <map:pipeline>
      <map:match pattern="skinconf.xml">
        <map:generate src="cocoon://module.properties.properties" />
        <map:serialize />
      </map:match>
    </map:pipeline>

salu2
-- 
Thorsten Scherler                                 thorsten.at.apache.org
Open Source Java                      consulting, training and solutions


Mime
View raw message