forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sina K. Heshmati" <s...@khakbaz.com>
Subject RE: [jira] Commented: (FOR-1059) Reusable Panels for Core Themes
Date Wed, 26 Dec 2007 09:41:38 GMT
"Thorsten Scherler (JIRA)" said:

> Thorsten Scherler commented on FOR-1059:
> ----------------------------------------
> 
> Hmm, I do not understand: "Please do NOT add these patches as it will affect other
> Forrest instances using the Dispatcher. " Sure it will effect other - more all
> other - instance of the dispatcher.
> 
> I reviewed the patch and applied it slightly changed. Thanks for your contribution
> Sina.
> 
I don't quite see how else I could have added the patch than by the issue tracker! Although,
you did the right thing by reviewing the patch and applying your changes prior to committing
the code.

> To 1)
> we use the fallback mechanism meaning if a plugin does not use its own structurer
> we use the one from core.
> The special case here is that pelt-html.panel.xml is already a panel and applying
> your patch as it is will affect all themes that are importing the panel.
> I slightly changed the patch so that the structurer directly is using the new
> chunks.
> 
> To 2) No, since the pelt theme will provide always a basic css structure. Now one
> has to override the different chunks.
>
Thanks for the answers.

-SinDoc


Mime
View raw message