forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thorsten Scherler (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FOR-1059) Reusable Panels for Core Themes
Date Wed, 26 Dec 2007 09:22:43 GMT

    [ https://issues.apache.org/jira/browse/FOR-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12554395
] 

Thorsten Scherler commented on FOR-1059:
----------------------------------------

Hmm, I do not understand: "Please do NOT add these patches as it will affect other Forrest
instances using the Dispatcher. " Sure it will effect other - more all other - instance of
the dispatcher. 

I reviewed the patch and applied it slightly changed. Thanks for your contribution Sina.

To 1) 
we use the fallback mechanism meaning if a plugin does not use its own structurer we use the
one from core. 
The special case here is that pelt-html.panel.xml is already a panel and applying your patch
as it is will affect all themes that are importing the panel. 
I slightly changed the patch so that the structurer directly is using the new chunks.

To 2) No, since the pelt theme will provide always a basic css structure. Now one has to override
the different chunks.

> Reusable Panels for Core Themes
> -------------------------------
>
>                 Key: FOR-1059
>                 URL: https://issues.apache.org/jira/browse/FOR-1059
>             Project: Forrest
>          Issue Type: Improvement
>          Components: Plugin: themes.core
>    Affects Versions: 0.9-dev
>            Reporter: Sina K. Heshmati
>            Priority: Minor
>             Fix For: 0.9-dev
>
>         Attachments: FOR-1059-themes-20071218-01.patch, FOR-1059-themes-20071218-01.tar.gz
>
>
> It's useful to have reusable panels for each theme [1]. I'm sending the html-pelt theme
that's been chunked into different templates.
> [1] http://marc.info/?l=forrest-dev&m=119738096213489&w=2

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message