forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Crossley <cross...@apache.org>
Subject Re: svn commit: r546173 - in /forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.input.skos: resources/stylesheets/skos-to-document.xsl src/documentation/content/xdocs/glossary.xml
Date Tue, 12 Jun 2007 01:31:50 GMT
(Ross sent this to the svn@ list by mistake.)
-David

Ross Gardler wrote:
> rgardler wrote:
> 
> >URL: http://svn.apache.org/viewvc?view=rev&rev=546173
> >Log:
> >allow multiple definitions of glossary items (thanks to Oshani Seneviratne 
> >FOR-1006)
> 
> Great stuff Oshani, some minor comments...
> 
> >+    <em class="bold">
> 
> Why em class="bold"? the class does nothing since there is no addition
> to the CSS. Why not <strong> or <em>?
> 
> >+    <dl class="{local-name(.)}" id="{skos:prefLabel/text()}">
> 
> <dl> etc. is not valid, see FOR-1009.
> 
> Also, what is the intention of the class attribute here and elsewhere.
> There is no addition to the CSS files so this is meaningless at this
> time.
> 
> I suspect that this content is cut and paste from somewhere else. I
> committed it anyway as it is a very small amount of code, however, be
> careful about cut an paste code, it introduces errors and can give us
> problems from an ownership perspective.
> 
> All code you commit must be your own code, or must be license
> compatible, in which case we need to ensure we satisfy all licence
> conditions.

Mime
View raw message