forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ross Gardler (JIRA)" <j...@apache.org>
Subject [jira] Created: (FOR-987) Redundant code in forrest.build.xml
Date Fri, 13 Apr 2007 19:29:15 GMT
Redundant code in forrest.build.xml
-----------------------------------

                 Key: FOR-987
                 URL: https://issues.apache.org/jira/browse/FOR-987
             Project: Forrest
          Issue Type: Improvement
          Components: Core operations
    Affects Versions: 0.8-dev
            Reporter: Ross Gardler
            Priority: Trivial


In forrest.build.xml there is the followoing target:

<!-- Load properties from Forrest's default skinconf.xml, unless a user's is defined -->
  <target name="load-forrest-props" unless="skinconf.present">
    <xslt in="${forrest.core.webapp}/skinconf.xml"
           out="${project.temp-dir}/no-doctype-forrest-skinconf.xml"
           style="${forrest.core.webapp}/resources/stylesheets/strip-doctype.xsl">
      <xmlcatalog refid="fcatalog"/>
    </xslt>
<!-- Forrest skinconf should have been previously validated in build.xml -->
    <xmlproperty file="${project.temp-dir}/no-doctype-forrest-skinconf.xml"
                 collapseattributes="true"/>
  </target>

This target is never used in a skin based site (they always have skinconf present from the
seed).

Furthermore, since the core skinconf file no longer exists it breaks the dispatcher based
sites, which may not have a skinconf.

----

There may well be other redundant code that needs to be cleared out.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message