Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@forrest.apache.org
Received-SPF: neutral (herse.apache.org: local policy)
Date: Thu, 29 Mar 2007 09:13:46 +1000
From: David Crossley <crossley@apache.org>
To: dev@forrest.apache.org
Subject: Re: [jira] Closed: (FOR-765) forrest war and classpath issues with
 Jetty
Message-ID: <20070328231346.GV8546@igg.indexgeo.com.au>
References: <011d01c77188$f43196d0$650fa8c0@BrightonComputers.local>
 <460AF088.9080608@apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <460AF088.9080608@apache.org>
User-Agent: Mutt/1.4.2.2i

Ross Gardler wrote:
> Gav.... wrote:
> >From: Thorsten Scherler (JIRA)
> >>Subject: [jira] Closed: (FOR-765) forrest war and classpath issues with
> >>Jetty
> >>
> >>Thorsten Scherler closed FOR-765.
> >>---------------------------------
> >>
> >>    Resolution: Fixed
> >>
> >>Ok after recompiling forrest with 1.4 I got it starting and see the error
> >>David describes.
> >>
> >>Then I looked at the 'forrest war' output:
> >>...
> >>If using JDK 1.4 or above, make sure to set the Java environment variable
> >>-Djava.endorsed.dirs=/home/thorsten/src/apache/forrest/trunk/lib/endorsed
> >>e.g. in the TOMCAT_OPTS (3.3.x) or CATALINA_OPTS (4.x) env variable.
> >>...
> >>
> >>I followed above instructions by using:
> >>java -
> >>Djava.endorsed.dirs=/home/thorsten/src/apache/forrest/trunk/lib/endorsed/
> >>-jar start.jar
> >>
> >>...and 1.4 is working like a charm.

Thanks for figuring that out Thorsten.

> >I saw that message too, assumed it was Tomcat related rather than Jetty. 
> >And
> >then it says 'or above' , well with above 1.4 you don't need it at all, the
> >message is not accurate as Tomcat and Jetty work fine on 1.5.
> >
> >So you did the above Tomcat related message and got Jetty working on 1.4?
> >Sounds good then if it works, can the message be changed to include Jetty
> >as well as Tomcat as a fix suggestion.
> 
> The first part of the message is pretty clear "set the Java environment 
> variable ..."
> 
> The second part says "e.g. in the TOMCAT_OPTS..." which is a Tomcat 
> example. I don't read that to mean it is a Tomcat only instruction, only 
> that it is a Tomcat example.
> 
> However, if one person feels it is confusing, you can pretty sure it is 
> confusing for another.

I read it as Tomcat specific too. Thorsten chopped
off the top of the build message. It starts with:

"To run in Tomcat, add this to the config file (usually server.xml):
..."

> Nevertheless,  we can't possibly put examples for 
> all possible containers.

As i suggested in the issue comments, it might be better
to have a doc or FAQ for such quirks. Rather than clutter
the build output, just refer to the doc.

Did anyone try with an earlier version of Jetty, e.g. 4.2.23 ?

-David

> I'd say remove the e.g. and just leave it at "set the env variable".
> 
> You are also correct that this only affects Java 1.4, but I suspect it 
> may affect other java implementations since it is a class loading issue 
> and therefore dependant on what is bundled with the java implementation 
> in use.
> 
> I'd say change it to something like "In Sun Java 1.4 and possibly some 
> other Java implementations..."
> 
> Ross