forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ross Gardler <rgard...@apache.org>
Subject Re: [jira] Closed: (FOR-765) forrest war and classpath issues with Jetty
Date Wed, 28 Mar 2007 22:47:36 GMT
Gav.... wrote:
> 
>> -----Original Message-----
>> From: Thorsten Scherler (JIRA) [mailto:jira@apache.org]
>> Sent: Thursday, 29 March 2007 5:54 AM
>> To: dev@forrest.apache.org
>> Subject: [jira] Closed: (FOR-765) forrest war and classpath issues with
>> Jetty
>>
>>
>>      [ https://issues.apache.org/jira/browse/FOR-
>> 765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>>
>> Thorsten Scherler closed FOR-765.
>> ---------------------------------
>>
>>     Resolution: Fixed
>>
>> Ok after recompiling forrest with 1.4 I got it starting and see the error
>> David describes.
>>
>> Then I looked at the 'forrest war' output:
>> ...
>> If using JDK 1.4 or above, make sure to set the Java environment variable
>> -Djava.endorsed.dirs=/home/thorsten/src/apache/forrest/trunk/lib/endorsed
>> e.g. in the TOMCAT_OPTS (3.3.x) or CATALINA_OPTS (4.x) env variable.
>> ...
>>
>> I followed above instructions by using:
>> java -
>> Djava.endorsed.dirs=/home/thorsten/src/apache/forrest/trunk/lib/endorsed/
>> -jar start.jar
>>
>> ...and 1.4 is working like a charm.
> 
> I saw that message too, assumed it was Tomcat related rather than Jetty. And
> then it says 'or above' , well with above 1.4 you don't need it at all, the
> message is not accurate as Tomcat and Jetty work fine on 1.5.
> 
> So you did the above Tomcat related message and got Jetty working on 1.4?
> Sounds good then if it works, can the message be changed to include Jetty
> as well as Tomcat as a fix suggestion.

The first part of the message is pretty clear "set the Java environment 
variable ..."

The second part says "e.g. in the TOMCAT_OPTS..." which is a Tomcat 
example. I don't read that to mean it is a Tomcat only instruction, only 
that it is a Tomcat example.

However, if one person feels it is confusing, you can pretty sure it is 
confusing for another. Nevertheless,  we can't possibly put examples for 
all possible containers.

I'd say remove the e.g. and just leave it at "set the env variable".

You are also correct that this only affects Java 1.4, but I suspect it 
may affect other java implementations since it is a class loading issue 
and therefore dependant on what is bundled with the java implementation 
in use.

I'd say change it to something like "In Sun Java 1.4 and possibly some 
other Java implementations..."

Ross


Mime
View raw message