forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ross Gardler <rgard...@apache.org>
Subject Re: svn commit: r520650 - in /forrest/trunk/whiteboard/plugins: org.apache.forrest.plugin.input.doap/ org.apache.forrest.plugin.internal.dispatcher/ org.apache.forrest.plugin.output.solr/ org.apache.forrest.themes.core/themes/common/fo/ org.apache.forrest....
Date Wed, 21 Mar 2007 09:31:06 GMT
Cyriaque Dupoirieux wrote:
> le 21/03/2007 00:17 rgardler@apache.org a écrit :
>> Author: rgardler
>> Date: Tue Mar 20 16:17:47 2007
>> New Revision: 520650
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=520650
>> Log:
>> Enable *.vt.xml files to be located in the correct directory within 
>> themes.
>>   
> [...SNIP...]
> 
>> Modified: 
>> forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml

>>
>> URL: 
>> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml?view=diff&rev=520650&r1=520649&r2=520650

>>
>> ============================================================================== 
>>
>> --- 
>> forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml

>> (original)
>> +++ 
>> forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml

>> Tue Mar 20 16:17:47 2007
>> @@ -247,21 +247,21 @@
>>              </select>
>>          </match>
>>          <!-- Structurer tiles - You can group elements to a template 
>> and call it from any view. -->
>> -        <match pattern="resolve.tiles.**">
>> +        <match pattern="resolve.tiles.**-*">

...

>>   
> Ok, that's nice,
> Don't you think a pattern like :
> 
> <match pattern="resolve.*.tiles.*">
>     <location 
> src="{properties:resources}/themes/{properties:dispatcher.theme}/{1}/{2}.vt.xml"/>

> 
> 
> ...
> Would be clearer ?

Agreed.

> Or at least a pattern like the following to avoid to have the format in 
> the tiles filename :
> 
> <match pattern="resolve.tiles.**-*">
>  <select type="exists">
>    <location 
> src="{properties:resources}/themes/{properties:dispatcher.theme}/{2}/{1}.vt.xml" 
> 
> 
> WDOT ?

Also a good solution.

I didn't want to mess with the structure of the pattern as I'm not 
familiar enough with dispatcher to know what side effects this may have. 
If you think it is safe to do this, then I agree bother are better than 
the current implementation.

I prefer the first option.

Ross

Mime
View raw message