From dev-return-25780-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org Fri Sep 22 08:59:11 2006 Return-Path: Delivered-To: apmail-forrest-dev-archive@www.apache.org Received: (qmail 12654 invoked from network); 22 Sep 2006 08:59:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 22 Sep 2006 08:59:11 -0000 Received: (qmail 97102 invoked by uid 500); 22 Sep 2006 08:59:10 -0000 Delivered-To: apmail-forrest-dev-archive@forrest.apache.org Received: (qmail 96944 invoked by uid 500); 22 Sep 2006 08:59:10 -0000 Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@forrest.apache.org List-Id: Delivered-To: mailing list dev@forrest.apache.org Received: (qmail 96928 invoked by uid 99); 22 Sep 2006 08:59:10 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Sep 2006 01:59:10 -0700 Authentication-Results: idunn.apache.osuosl.org smtp.mail=rgardler@apache.org; spf=permerror X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received-SPF: error (idunn.apache.osuosl.org: domain apache.org from 212.23.3.142 cause and error) Received: from [212.23.3.142] ([212.23.3.142:52824] helo=rutherford.zen.co.uk) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id C0/72-06791-DD5A3154 for ; Fri, 22 Sep 2006 01:59:09 -0700 Received: from [217.155.85.142] (helo=[217.155.85.137]) by rutherford.zen.co.uk with esmtp (Exim 4.50) id 1GQgsE-0000b1-MY for dev@forrest.apache.org; Fri, 22 Sep 2006 08:59:06 +0000 Message-ID: <4513A5CC.8040007@apache.org> Date: Fri, 22 Sep 2006 09:58:52 +0100 From: Ross Gardler User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) MIME-Version: 1.0 To: dev@forrest.apache.org Subject: Re: [jira] Commented: (FOR-934) i18n language override menu References: <8164971.1158760822766.JavaMail.jira@brutus> <2E8FF5A4-7DB9-456B-BB7D-5DC09B83B330@mac.com> <45116160.9060605@apache.org> <1158829832.5384.22.camel@localhost> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Originating-Rutherford-IP: [217.155.85.142] X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Sjur Moshagen wrote: > Den 21. sep. 2006 kl. 12.10 skrev Thorsten Scherler: > >>> I've not been following the i18n discussions, but I have to admit that >>> when I saw Thorstens comments I wondered "why not core?". >>> >>> I'm not doing the work on this so do it however you like. But if you >>> want my (possibly uninformed) opinion then I'd say core is the right >>> place. >>> >> >> Hmm, after all the feature contains a dispatcher contract. Further who >> said core cannot be in a plugin? In my previous reply I missed the "contains a dispatcher contract" part... I got the impression that this code would work with skins too is that not the case? The dispatcher contract should be part of the dispatcher, not part of core, or another internal plugin. We do not have a mechanism for plugin dependencies and I don't think this use case warrants one. If the i18n work is useless without this contract then this is of no use to Forrest users who are not using dispatcher, therefore it is a dispatcher feature. Can it be generalised for skins? Ross