forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cyriaque Dupoirieux <Cyriaque.Dupoiri...@pcotech.fr>
Subject Re: svn commit: r442037 - /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pelt.fv
Date Wed, 13 Sep 2006 11:06:26 GMT
le 13/09/2006 12:36 Gav.... a écrit :
> Sorry guys, didn't realise pelt.fv got its content from elsewhere, I thought
> it was hand coded.
>   
That's not the problem :
the contracts - generally - have arguments.
If the rendering is different when you put extra <CR> or <Spaces> 
whereas we are in an XML file, then we have to correct the contract - 
which is responsible of the layout.

    Your modification has corrected the rendering of the current site, 
but if someone else start a pelt.fv from scratch he will certainly make 
the same mistake (which is not a mistake after all) and be surprised to 
see the result.

    I have corrected the contract which was the culprit and now anyone 
can add a credit like this :

    <credit role="accueil">
        <name>Built with Cocoon</name>
        <url>

http://cocoon.apache.org/</url>
        <image>
           

       
http://forrest.apache.org/images/built-with-cocoon.gif



                                                                </image>

</credit>

Without problem...

Salutations,
Cyriaque,

> Gav...
>
>   
>> -----Original Message-----
>> From: Cyriaque Dupoirieux [mailto:Cyriaque.Dupoirieux@pcotech.fr]
>> Sent: Tuesday, 12 September 2006 3:51 PM
>> To: dev@forrest.apache.org
>> Subject: Re: svn commit: r442037 -
>> /forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pe
>> lt.fv
>>
>> le 12/09/2006 02:48 David Crossley a écrit :
>>     
>>> The more complete fix is to find which stylesheets use this
>>> information and ensure use of the normalize-space() function.
>>> Otherwise everyone else who has whitespace in their source
>>> will have the same problem. Such whitespace in xml is legitimate.
>>>
>>>       
>> Done,
>> Excellent remark David. We have to solve problems and not suppress the
>> causes ;-) .
>>     
>>> BTW, i wonder why we use a remote resource. I am sure that
>>> we have that image in SVN.
>>>
>>>       
>> This, I have not checked.
>>
>> Salutations,
>> Cyriaque,
>>     
>>> -David
>>>
>>>
>>>       
>>>> Author: gmcdonald
>>>> Date: Sun Sep 10 16:48:49 2006
>>>> New Revision: 442037
>>>>
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=442037
>>>> Log:
>>>> Whitespace and illegal character cleanup to fix FOR-929
>>>>
>>>> Modified:
>>>>
>>>>         
>> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
>> t.fv
>>     
>>>> Modified:
>>>>         
>> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
>> t.fv
>>     
>>>> URL:
>>>>         
>> http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.f
>> orrest.themes.core/themes/pelt.fv?view=diff&rev=442037&r1=442036&r2=442037
>>     
>> ==========================================================================
>> ====
>>     
>>>> ---
>>>>         
>> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
>> t.fv (original)
>>     
>>>> +++
>>>>         
>> forrest/trunk/whiteboard/plugins/org.apache.forrest.themes.core/themes/pel
>> t.fv Sun Sep 10 16:48:49 2006
>>     
>>>> @@ -416,8 +416,7 @@
>>>>                <credit role="accueil">
>>>>                  <name>Built with Cocoon</name>
>>>>                  <url>http://cocoon.apache.org/</url>
>>>> -                <image>
>>>> -                  http://forrest.apache.org/images/built-with-
>>>>         
>> cocoon.gif</image>
>>     
>>>> +                <image>http://forrest.apache.org/images/built-with-
>>>>         
>> cocoon.gif</image>
>>     
>>>>                </credit>
>>>>              </credits>
>>>>            </forrest:property>
>>>>
>>>>
>>>>         
>>>
>>>       
>> --
>> No virus found in this incoming message.
>> Checked by AVG Free Edition.
>> Version: 7.1.405 / Virus Database: 268.12.3/444 - Release Date: 9/11/2006
>>     
>
>
>
>
>   

Mime
View raw message