forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cyriaque Dupoirieux <Cyriaque.Dupoiri...@pcotech.fr>
Subject Re: svn commit: r442870 - /forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/skinconf.xml
Date Wed, 13 Sep 2006 07:30:43 GMT
le 13/09/2006 08:54 crossley@apache.org a écrit :
> Author: crossley
> Date: Tue Sep 12 23:54:39 2006
> New Revision: 442870
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=442870
> Log:
> Fix plugin name.
>
> Modified:
>     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/skinconf.xml
>
> Modified: forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/skinconf.xml
> URL: http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/skinconf.xml?view=diff&rev=442870&r1=442869&r2=442870
> ==============================================================================
> --- forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/skinconf.xml
(original)
> +++ forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/src/documentation/skinconf.xml
Tue Sep 12 23:54:39 2006
> @@ -24,7 +24,7 @@
>  <skinconfig>
>    &skinconf-common;
>  
> -  <project-name>Plugin: structurer internal</project-name>
> -  <project-description>org.apache.forrest.plugin.internal.structurer plugin for
Apache Forrest</project-description>
> +  <project-name>Plugin: dispatcher internal</project-name>
> +  <project-description>org.apache.forrest.plugin.internal.dispatcher plugin for
Apache Forrest</project-description>
>   
>  
>  </skinconfig>
>   
The dispatcher should not use it because some contracts take this 
information in argument.
You are right to correct it but the main problem is that skins should be 
a plug in mecanism just like dispatcher and themer...
(In the same way, guys using the dispatcher have several files or 
directory copied to the build directory whereas their site doen't need 
them because they belong to the skinned site...)

Maybe we should open a FOR to remove all the skin specific mecanisms 
from the core and extract them into a skin plugin, WDOT ?
(cf. http://issues.apache.org/jira/browse/FOR-799 and 
http://marc.theaimsgroup.com/?l=forrest-dev&m=114654658417893&w=2)

Salutations,
Cyriaque,
>
>
>   

Mime
View raw message