forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gav...." <brightoncomput...@brightontown.com.au>
Subject RE: Dispatcher i18n update + three more issues
Date Mon, 25 Sep 2006 23:14:54 GMT


> -----Original Message-----
> From: Ross Gardler [mailto:rgardler@apache.org]
> Sent: Monday, 25 September 2006 10:54 PM
> To: dev@forrest.apache.org
> Subject: Re: Dispatcher i18n update + three more issues
> 
> Gav.... wrote:
> 
> >> 2) There should probably be a default/fallback ContractsMessages.xml
> >> file, which should really be the file above (ie the English one, if
> >> one wants to have English as the fallback language, which I expect
> >> one does). Not having one will at least cause some noise in the log
> >> files, and might also generate errors
> >
> > Ok, so exactly the same file, no changes apart from the file name ?
> >
> > No sure how others do it, but I would just copy the file, give it the
> > New name and then add it to our svn with 'svn add filename.xml' and then
> > Commit it. So, again no patch needed.
> 
> To copy a file in svn do "svn cp SRC_FILE DEST_FILE" this has the
> advantage of keeping the SVN history for the file.

Ok Sounds good. How do you go about applying patches locally then? 
Suppose I'm downloading Sjurs internal.xmap patch, normally I just
Overwrite the current version with the patched version, is there a
Better way?

> 
> However, be wary of copying files (as opposed to moving). If you have
> two files that are identical, and are likely to remain identical, as is
> the case here, this is usually an indicator of doing something the wrong
> way.
> 
> In this case shouldn't the fallback be defined as a specific language,
> i.e. English. In which case the fallback should be
> "ContractsMessages_en.xml" shouldn't it (as opposed to
> "ContractMessages.xml").

Sounds like the best way, haven't tested Sjurs patches yet, but hopefully
Then that wont mean having ?locale=en in the url for the default.

> 
> ...
> 
> > I guess once the jira issues you created are applied then we'll be able
> to
> > Test these out also.
> >
> > I'm going to download your patches and try them out anyway.
> 
> Remember you are committer Gav. If you find they work then commit them,
> don't wait for others to test them as well.

No problem, will do as soon as I can.

Gav...

> 
> > But I think a new Jira issue should be made to remember to do these,
> maybe
> > as a subtask as one of the others? Sub-tasks don't get used often enough
> > IMHO
> 
> +1
> 
> > Great work on all this i18n stuff !! :)
> 
> +1000
> 
> Ross
> 
> 
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.405 / Virus Database: 268.12.8/455 - Release Date: 9/22/2006




Mime
View raw message