forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thorsten.scher...@wyona.com>
Subject Re: svn commit: r428699 - /forrest/trunk/main/java/org/apache/forrest/conf/ForrestConfModule.java
Date Fri, 04 Aug 2006 14:04:50 GMT
El vie, 04-08-2006 a las 13:44 +0100, Ross Gardler escribió:
> thorsten@apache.org wrote:
> > Author: thorsten
> > Date: Fri Aug  4 04:41:38 2006
> > New Revision: 428699
> 
> ...
> 
> > +        } catch (Exception e) {
> > +        	getLogger().error("Opps, something went wrong.",e);
> > +        }
> 
> -1 (to this addition only, other changes in this commit are OK - see 
> discussion thread)
> 
> This chage is swallowing exceptions and preventing Cocoon reporting them 
> to the user.
> 

Forgot to throw them, thx for pointing out.

salu2
-- 
Thorsten Scherler
COO Spain
Wyona Inc.  -  Open Source Content Management  -  Apache Lenya
http://www.wyona.com                   http://lenya.apache.org
thorsten.scherler@wyona.com                thorsten@apache.org


Mime
View raw message