forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cyriaque Dupoirieux <Cyriaque.Dupoiri...@pcotech.fr>
Subject Re: svn commit: r423454 - /forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
Date Fri, 21 Jul 2006 08:25:33 GMT
le 19/07/2006 15:37 Thorsten Scherler a écrit :
> El mié, 19-07-2006 a las 13:01 +0000, cdupoirieux@apache.org escribió:
>   
>> Author: cdupoirieux
>> Date: Wed Jul 19 06:01:17 2006
>> New Revision: 423454
>>
>> URL: http://svn.apache.org/viewvc?rev=423454&view=rev
>> Log:
>> FOR-893 - We have encountered a strange problem with the pattern 'resolve.structurer.**'.
>> The {1} sometimes matches nothing, whereas {../1} is OK.
>> On the contrary, the {../1} sometimes matches nothing, whereas {1} is OK.
>> As a temporary workaround, we put {../1}{1} which covers all the cases.
>>
>> Modified:
>>     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
>>
>> Modified: forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
>> URL: http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml?rev=423454&r1=423453&r2=423454&view=diff
>> ==============================================================================
>> --- forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
(original)
>> +++ forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
Wed Jul 19 06:01:17 2006
>>     
>
> ...
>   
>> @@ -142,18 +150,18 @@
>>        <select type="exists">
>>          <!-- project-based 
>>            url-based (url location) -->
>> -        <location src="{project:resources}/structurer/url/{1}{project:theme-ext}"
/>
>> +	  <location src="{project:resources}/structurer/url/{../1}{1}{project:theme-ext}"
/>
>>  
>>     
>
> I think we should not apply the workaround to locations that are not
> effected by this weirdness. 
>   
Why do you think that I should not apply the workaround here also ?
> The problem occurs only in actions that have an xpath like
> select/action/parameter. 
>
> For example the select/action[@type='sourcetype'] is working like a
> charm with {1} in @src.
>
> Maybe it would be the best to adjust the
> action[@type='resourceTypeAction'] and
> action[@type='RecursiveDirectoryTraversalAction'] to add a @src='{1}'
> and change the processing in the java to use the @src instead of the
> <parameter value="{../1}" name="request"/>.
>   
Where is the stylesheet (or java class) making this xpath selection ?
If you tell me, I may have the time to see what's the problem.
(Or we can do what I have done with the php plugin : <map:match 
type="regexp" pattern="^resolve.structurer.(.*?)([^/]*)$"> ? and use {1}{2})
> However the whole issue smells really fishy and we need to get to the
> bottom of this issue.
>
> My problem is that I need to setup a test project to *see* the bug.
>
> Maybe you can attach a small project to the issue that I can test?
>   
I will try next week...

Salutations,
Cyriaque,
> salu2
>   

Mime
View raw message