forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thors...@apache.org>
Subject Re: svn commit: r423454 - /forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
Date Fri, 21 Jul 2006 11:26:20 GMT
El vie, 21-07-2006 a las 12:37 +0200, Cyriaque Dupoirieux escribió:
> le 21/07/2006 11:34 Thorsten Scherler a écrit :
> > El vie, 21-07-2006 a las 10:25 +0200, Cyriaque Dupoirieux escribió:
> >   
> >> le 19/07/2006 15:37 Thorsten Scherler a écrit :
> >>     
> >>> El mié, 19-07-2006 a las 13:01 +0000, cdupoirieux@apache.org escribió:
> >>>   
> >>>       
> >>>> Author: cdupoirieux
> >>>> Date: Wed Jul 19 06:01:17 2006
> >>>> New Revision: 423454
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=423454&view=rev
> >>>> Log:
> >>>> FOR-893 - We have encountered a strange problem with the pattern 'resolve.structurer.**'.
> >>>> The {1} sometimes matches nothing, whereas {../1} is OK.
> >>>> On the contrary, the {../1} sometimes matches nothing, whereas {1} is
OK.
> >>>> As a temporary workaround, we put {../1}{1} which covers all the cases.
> >>>>
> >>>> Modified:
> >>>>     forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
> >>>>
> >>>> Modified: forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
> >>>> URL: http://svn.apache.org/viewvc/forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml?rev=423454&r1=423453&r2=423454&view=diff
> >>>> ==============================================================================
> >>>> --- forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
(original)
> >>>> +++ forrest/trunk/whiteboard/plugins/org.apache.forrest.plugin.internal.dispatcher/locationmap.xml
Wed Jul 19 06:01:17 2006
> >>>>     
> >>>>         
> >>> ...
> >>>   
> >>>       
> >>>> @@ -142,18 +150,18 @@
> >>>>        <select type="exists">
> >>>>          <!-- project-based 
> >>>>            url-based (url location) -->
> >>>> -        <location src="{project:resources}/structurer/url/{1}{project:theme-ext}"
/>
> >>>> +	  <location src="{project:resources}/structurer/url/{../1}{1}{project:theme-ext}"
/>
> >>>>  
> >>>>     
> >>>>         
> >>> I think we should not apply the workaround to locations that are not
> >>> effected by this weirdness. 
> >>>   
> >>>       
> >> Why do you think that I should not apply the workaround here also ?
> >>     
> >
> > Because this works fine with {1}.
> If you are sure...

yes, I am.

> >  Further you applied it only in some in
> > others not.
> I believed I had applied for the whole pattern.

Yeah, you are right.

> >  Later this will raise the question why. If we only apply the
> > workaround for the effected code then we know later on which code we
> > need to fix.
> >   
> Ok, Do I remove it from the sourceType 

Yes, since the path is match/select/act[not(parameter)]

> and ResourceTypeAction ?

No, since the path is match/select/act[parameter]

...
> >
> > BTW I noticed that your IDE seems to be miss-configured. Since this
> > commit the locationmap.xml has tabs but we use spaces. Please update
> > your configuration. 
> >
> >   
> Just few lines were changed with tabs, not the whole file, isn't it ?

Yes, but this few lines causes an inconsistency. 

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Mime
View raw message