Return-Path: 
 <dev-return-24611-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 97016 invoked from network); 7 Jun 2006 11:03:51 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 7 Jun 2006 11:03:51 -0000
Received: (qmail 13222 invoked by uid 500); 7 Jun 2006 11:03:50 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 13058 invoked by uid 500); 7 Jun 2006 11:03:50 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
List-Post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
List-Id: <dev.forrest.apache.org>
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 13046 invoked by uid 99); 7 Jun 2006 11:03:49 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jun 2006 04:03:49 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Received: from [212.23.3.140] (HELO pythagoras.zen.co.uk) (212.23.3.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Jun 2006 04:03:49 -0700
Received: from [217.155.85.142] (helo=[217.155.85.137])
	by pythagoras.zen.co.uk with esmtp (Exim 4.30)
	id 1Fnvou-0005nn-9o
	for dev@forrest.apache.org; Wed, 07 Jun 2006 11:03:28 +0000
Message-ID: <4486B274.9030803@apache.org>
Date: Wed, 07 Jun 2006 12:03:16 +0100
From: Ross Gardler <rgardler@apache.org>
User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: dev@forrest.apache.org
Subject: Re: svn commit: r412354 -
 /forrest/trunk/site-author/content/xdocs/pluginDocs/plugins_0_80/usingPlugins.xml
References: <20060607101330.AE0371A983A@eris.apache.org>
 <4486AA06.20403@apache.org> <4486B0C7.8090208@pcotech.fr>
In-Reply-To: <4486B0C7.8090208@pcotech.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
X-Originating-Pythagoras-IP: [217.155.85.142]
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

Cyriaque Dupoirieux wrote:
> le 07/06/2006 12:27 Ross Gardler a =C3=A9crit :

>>> -        <a=20
>>> href=3D"http://issues.apache.org/jira/browse/FOR-388">FOR-388</a>

=2E..

>> Should we really be deleting the warning about this?
>=20
> I think so, or at least we need to change it  may be something like :
> "Until issue <a=20
> href=3D"http://issues.apache.org/jira/browse/FOR-388">FOR-388</a> is fi=
xed=20
> to enable the use of plugins in-place, any change to sources needs to=20
> restart forrest"

OK, I'm doing that now, with a minor modification of adding the=20
local-deploy option.

>> Should the issue really be closed? (see [1])
>>
> No, we should reopen it. I didn't understand the "in place" ;-) . I=20
> believed it was "instead of" the remote version...

That makes sense. I've reopened the issue but moved its fixed version to =

0.9. Your work on this is worthy of the 0.8 release. I've also clarified =

what is meant by "in place".

>=20
>>> +      <p>If you need to enhance an existing plugin functionality,=20
>>> you should not edit a standard plugin sources.</p>
>>> +      <p>First, copy the whole plugin directory either in a plugins =

>>> directory in your project tree or, if the plugin is used by several=20
>>> projects, +      in a different location outside any project=20
>>> directory.</p>
>>
>>
>> I'm not sure we want to encourage users working in this way. We want=20
>> them to enhance Forrest code and provide patches. This comment=20
>> encourages them to fork the code doesn't it?
>=20
> You are right, Maybe (please correct my bad english...) :

I'll make the edits you suggest with some minor mods (not for bad=20
English though ;-)

Thanks,
Ross