Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@forrest.apache.org
Message-ID: <19106712.1150653990145.JavaMail.jira@brutus>
Date: Sun, 18 Jun 2006 18:06:30 +0000 (GMT+00:00)
From: "Ross Gardler (JIRA)" <jira@apache.org>
To: dev@forrest.apache.org
Subject: [jira] Closed: (FOR-898) New tag into skinconf.dtd (google-id)
In-Reply-To: <2094837.1150647569772.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/FOR-898?page=all ]
     
Ross Gardler closed FOR-898:
----------------------------

    Resolution: Invalid
     Assign To: Ross Gardler

We should not add information that is specific to a particular feature to skinconf.dtd Not everyone wants to use Google Analytics. Therefore the changes should be in the project not core. However, as Kristo reports the skinconf.dtd is too restricitive to allow things like this to be added.

There are two ways of achieving the desired results, both of which are part of trunk and working today. If you are interested in either feature then joi us on the dev list and we'll work out how to achieve what you need:

1) Use dispatcher rather than skins - dispatcher is currently in the whiteboard and is operational. 

2) Use the new forrest.properties.xml configuration option that allows arbitrary configuration properties to be exposed in the sitemap. This feature is in core, but is currently undocumented.

> New tag into skinconf.dtd (google-id)
> -------------------------------------
>
>          Key: FOR-898
>          URL: http://issues.apache.org/jira/browse/FOR-898
>      Project: Forrest
>         Type: New Feature

>   Components: Skins (general issues)
>     Versions: 0.7
>     Reporter: Kristo Helasvuo
>     Assignee: Ross Gardler
>     Priority: Trivial

>
> Adding Google Analytics support for your skin currently requires modification of site2xhtml.xsl. For example in main/webapp/skins/pelt/xslt/html.
> You need to add Google-provided JS scripts into lines just before /body (around line 363). These JS's include site-specific tracking id, which should be placed in skinconf.xml (or site.xml?) instead - if you want to use your skin to generate other sites too.
> Adding arbitrary googleid-node in skinconf.xml however results in invalid xml and projects forrest.properties-file is not visible during xslt processing (is it not?). My suggestion would be to add googleid-node into the skinconfig.dtd.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira