forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Crossley (JIRA)" <>
Subject [jira] Commented: (FOR-891) css-validator reports CSS errors and many warnings for pelt skin
Date Fri, 02 Jun 2006 03:34:30 GMT
    [ ] 

David Crossley commented on FOR-891:

Gavin, i tried applying your patch but it makes some changes which don't seem correct (so
not yet applied).

The top-right rounded corners have disappeared from tabs and the top search box.

The colour for unselected tabs seems to get a new default colour. This over-rides the value
from the project's skinconf.xml file. I wonder if these default background-color values need
to happen in the generated css files.

Also please do not add extra tabs to the files (we use spaces). This creates unnecessary diffs
and obscures the real changes, e.g. see #level2tabs in your patch.

When providing patches, please also tell what you have changed in general terms so that we
can add a sensible svn log message for the commit.

> css-validator reports CSS errors and many warnings for pelt skin
> ----------------------------------------------------------------
>          Key: FOR-891
>          URL:
>      Project: Forrest
>         Type: Bug

>   Components: Skins (general issues), Documentation and website
>     Versions: 0.8-dev
>     Reporter: David Crossley
>     Assignee: Gavin
>     Priority: Blocker
>      Fix For: 0.8-dev
>  Attachments: screen.css.diff
> Our home page does not pass CSS validation with

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message