forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Crossley <cross...@apache.org>
Subject Re: [jira] Commented: (FOR-891) css-validator reports CSS errors and many warnings for pelt skin
Date Thu, 08 Jun 2006 02:27:28 GMT
Gav.... wrote:
> > David Crossley wrote:
> > > When providing patches, please also tell what you have changed in
> > general
> > > terms so that we can add a sensible svn log message for the commit.
> > 
> > Okey Dokey.
> 
> Erm, So I did not do that in this latest patch.
> 
> What I did in this case is obvious as it is only a very small diff.

The point of my comment was that the committer needs to
add a one or two line statement about what was changed.
Often the committer does not have time to figure out what
has changed and why. Much easier if the patch provider tells.

I did not intend for you to make big explanation and
justificiation. But if you feel the need, then provide
extra explanation like you did below.

> The reason for the changes is because of previous mixing of background
> Values - making W3C Validator complain and fail the CSS. 
> 
> You can use 'top left' 'top right' 'center right' etc etc but you can not
> mix these values with pixel units.

> You have the choice of using keyword values such as above, or you can
> specify by using percentage values, or you can specify by using pixel
> values. You can mix percentage and pixel values, but not keywords.
> 
> As most of the css uses keywords I chose to get rid of the pixel values and
> replace with keyword positions to match the other values.
> 
> This has made a very minor difference in the positioning to the arrows by
> about 1px but not really noticeable and the positioning is still relevant to
> their purpose. It would be far more work to convert all values from all
> elements into % or px. I hope you agree with the improvements to make the
> CSS valid.

I don't know. I just applied the patch and it didn't seem
to break anything. Thanks.

-David

Mime
View raw message