forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gav...." <brightoncomput...@brightontown.com.au>
Subject RE: [jira] Commented: (FOR-891) css-validator reports CSS errors and many warnings for pelt skin
Date Wed, 07 Jun 2006 12:27:32 GMT

> >
> > When providing patches, please also tell what you have changed in
> general
> > terms so that we can add a sensible svn log message for the commit.
> 
> Okey Dokey.
> 
> Gav...

Erm, So I did not do that in this latest patch.

What I did in this case is obvious as it is only a very small diff.

The reason for the changes is because of previous mixing of background
Values - making W3C Validator complain and fail the CSS. 

You can use 'top left' 'top right' 'center right' etc etc but you can not
mix these values with pixel units.

You have the choice of using keyword values such as above, or you can
specify by using percentage values, or you can specify by using pixel
values. You can mix percentage and pixel values, but not keywords.

As most of the css uses keywords I chose to get rid of the pixel values and
replace with keyword positions to match the other values.

This has made a very minor difference in the positioning to the arrows by
about 1px but not really noticeable and the positioning is still relevant to
their purpose. It would be far more work to convert all values from all
elements into % or px. I hope you agree with the improvements to make the
CSS valid.

Gav...



Mime
View raw message