forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gav...." <brightoncomput...@brightontown.com.au>
Subject RE: [jira] Commented: (FOR-891) css-validator reports CSS errors and many warnings for pelt skin
Date Wed, 07 Jun 2006 12:13:24 GMT
Hi All,


> -----Original Message-----
> From: David Crossley (JIRA) [mailto:jira@apache.org]
> Sent: Friday, 2 June 2006 11:35 AM
> To: dev@forrest.apache.org
> Subject: [jira] Commented: (FOR-891) css-validator reports CSS errors and
> many warnings for pelt skin
> 
>     [ http://issues.apache.org/jira/browse/FOR-
> 891?page=comments#action_12414345 ]
> 
> David Crossley commented on FOR-891:
> ------------------------------------
> 
> Gavin, i tried applying your patch but it makes some changes which don't
> seem correct (so not yet applied).

Ok, there may have been a few default colors I used to get rid of the
'warnings' , they could have been corrected afterwards but I'll try and
match them up.

> 
> The top-right rounded corners have disappeared from tabs and the top
> search box.

Oops, yes I spotted that all the round corners were using id attributes -
except one which uses the class instead e.g. -

#roundtop

#roundbottom

.roundtopsmall

#roundbottomsmall


So I do not understand the reason for this inconsistency, my mistake was
changing the . to a # and not changing the corresponding xml.


> 
> The colour for unselected tabs seems to get a new default colour. This
> over-rides the value from the project's skinconf.xml file. I wonder if
> these default background-color values need to happen in the generated css
> files.

Sorry, been dispatcher minded for too long now (that's another thread) and I
did not remember the skinconf.xml file.

Most of the 'Warnings' from the CSS Validator (which is basically a
judgement call, fix them if you want but they are not failures/errors) are
that there are missing background-color declarations when using color and
vice-versa. The W3C may insist on these in future as fallbacks so that
inherited parent colors do not clash with their children, so we may as well
fix them.

The question now then is, where do you want them ?
I will make sure I spend longer finding better default colors for them
before sending the patch in. The new patch I sent today cures the Errors and
so will pass validation. I will work on the Warnings next.

> 
> Also please do not add extra tabs to the files (we use spaces). This
> creates unnecessary diffs and obscures the real changes, e.g. see
> #level2tabs in your patch.

Bummer, I DID use spaces! For some reason, a few of the lines were (upon
initial opening of the file, before any changes by me) indented further in
that most, so I backspaced them once which seemed to get rid of a tab, then
spaced in 2 spaces to line them up again. 

This may be another Windows Quirk I don't know, my Vim is set up correctly.

> 
> When providing patches, please also tell what you have changed in general
> terms so that we can add a sensible svn log message for the commit.

Okey Dokey.

Gav...

> 
> > css-validator reports CSS errors and many warnings for pelt skin
> > ----------------------------------------------------------------
> >
> >          Key: FOR-891
> >          URL: http://issues.apache.org/jira/browse/FOR-891
> >      Project: Forrest
> >         Type: Bug
> 
> >   Components: Skins (general issues), Documentation and website
> >     Versions: 0.8-dev
> >     Reporter: David Crossley
> >     Assignee: Gavin
> >     Priority: Blocker
> >      Fix For: 0.8-dev
> >  Attachments: screen.css.diff
> >
> > Our home page does not pass CSS validation with
> http://jigsaw.w3.org/css-validator/
> 
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
> 
> 
> 
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.394 / Virus Database: 268.8.1/354 - Release Date: 6/1/2006



Mime
View raw message