forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thors...@apache.org>
Subject Re: Dispatcher and linking to image resources (Was: ForrestBot build for forrest-sample-2 FAILED)
Date Sun, 04 Jun 2006 11:47:31 GMT
El dom, 04-06-2006 a las 17:52 +1000, David Crossley escribió:
> Thorsten Scherler wrote:
> > David Crossley escribi??:
> > > Forrestbot@forrest.zones.apache.org wrote:
> > > > Automated build for forrest-sample-2 FAILED
> > > > ...
> > > > ...
> > > >      [java] X [0]                                     /icon-b.png	BROKEN:
/export/home/config/forrestbot-trunk/conf/work/forrest-sample-2/src/documentation/content/xdocs/icon-b.png
(No such file or directory)
> > > > ...
> > > 
> > > This same example works using skins.
> > > 
> > > <img src="/icon-b.png"  ...
> > > 
> > > The resources.xmap and locationmap resolve to find 
> > > source file in src/documentation/resources/images/ directory.
> > > 
> > > However with Dispatcher it seems to fail the locationmap
> > > and tries to find it at xdocs/icon-b.png
> > > 
> > > It is a silly example and perhaps it should be removed
> > > but why the difference between skins and Dispatcher?
> > 
> > The main reason is that png can be generate from svg. This is controlled
> > by skins/dispatcher. Maybe the best would be to extract the svg
> > generation to a plugin of its own (it is a couple of dispatcher
> > contracts and structurer definitions).
> 
> But the abovementioned link works fine as-is in 'forrest run' mode.

Need to test that but I am on the run again.

> > The problem with the resources.xmap is that it is a mix between skin
> > specific matches (like round corner) and general core matches. This xmap
> > I personally consider as one of the highest complex code in our whole
> > code base that is the reason why I did not yet found the time to slim it
> > down to a resources-core.xmap and resources-skin.xmap.
> > 
> > Will try to have a look tomorrow.
> 
> Is that wise when we are trying to crank out the release?

I have not said that I want to split them for the release, I wanted to
say I will have a look at the issue. BTW Cyriaque wrote a thread about
cleaning up dispatcher locations for resources.

> It works fine in html production now.

ok, did you fixed it with
http://svn.apache.org/viewvc?rev=411535&view=rev ?

Thanks, very much!

> 
> BTW, i see that the dispatcher copy of resources.xmap does not
> use the locationmap at all, whereas the main one does.
> 

We (I think Ross mainly did it) updated the xmap and extracted the
matches to lm recently. The dispatcher resources.xmap did not got
adopted after this changes.

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Mime
View raw message