forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin <forr...@kegcl.demon.co.uk>
Subject Re: Dispatcher and linking to image resources (Was: ForrestBot build for forrest-sample-2 FAILED)
Date Sat, 03 Jun 2006 12:40:04 GMT
On Sat, 2006-06-03 at 08:43 +1000, David Crossley wrote:
> Gav.... wrote:
> > 
> > > From: David Crossley
> > > 
> > > Forrestbot@forrest.zones.apache.org wrote:
> > > > Automated build for forrest-sample-2 FAILED
> > > > ...
> > > > ...
> > > >      [java] X [0]                                     /icon-b.png
> > > 	BROKEN: /export/home/config/forrestbot-trunk/conf/work/forrest-
> > > sample-2/src/documentation/content/xdocs/icon-b.png (No such file or
> > > directory)
> > > > ...
> > > 
> > > This same example works using skins.
> > > 
> > > <img src="/icon-b.png"  ...
> > > 
> > > The resources.xmap and locationmap resolve to find
> > > source file in src/documentation/resources/images/ directory.
> > > 
> > > However with Dispatcher it seems to fail the locationmap
> > > and tries to find it at xdocs/icon-b.png
> > 
> > That's right IIRC in how Dispatcher handles it, maybe this is why you think
> > my patch did not work, I patched it for Dispatcher.
> 
> No, this is just another separate issue.
> 
> Please see the comments at FOR-635 and the example
> in the 'forrest seed' site linking.html and linking.pdf
> 
> > Using the leading / to indicate 'relative from root' means it will look in 
> > Xdocs, that is how it is written. 
> >
> > e.g - 
> > 
> > 1. <img src="/icon-b.png"  ... results in looking in xdocs.
> > 2. <img src="icon-b.png"  ... results in looking in current directory of
> > requesting source file.
> > 3. <img src="images/icon-b.png"  ... results in looking in
> > src/documentation/resources/images/ directory.
> > 
> > 4. <img src="/images/icon-b.png"  ... results in looking in xdocs/images.
> > 
> > This is how I explained it was working and how the patch cured the problem
> > Of pdf images not showing. They work for me if the images are in the
> > specified directory according to how you define the URL. I offered to do it
> > A different way but was told to just 'fix the issue' of the pdf images not
> > Showing so I did that. 
> > 
> > Let me know if you want it doing differently.
> 
> Please see the comments at FOR-635. The sitemap
> and locationmap should be handling these. It should
> be independent of either skins or dispatcher.
> 
> Besides, your patch was to a stylesheet in
> main/webapp/skins/common/xslt/fo/document-to-fo.xsl
> i.e. skins.
> 
> Please focus on the stuff about FOR-635 over in the
> other thread. This current thread is about a locationmap
> or sitemap issue. It is not about the PDF generation.
> It happens in 'forrest run' or 'forrest site' when
> producing the html doc. It happens only in Dispatcher
> which is why we are getting errors from forrestbot
> for the dispatcher-enabled site, but not for the
> default skins-based site.

My earlier comment was probably confusing. One error is reported
from forrestbot for the dispatcher site. But for a skins site
it is not reported. However viewing the generated linking.html
image examples 1,2,3,8 and SVG magic are not rendered for both
dispatcher and skin enabled site.

Images not being renderd does not appear to be dispatcher related
as the thread title. It looks like just the examples with leading
forward slash are not matched in sitemap/locationmap.

Kevin

> -David
> 
> > > It is a silly example and perhaps it should be removed
> > > but why the difference between skins and Dispatcher?
> > > 
> > > -David
> > > 
> > > 
> > > --
> > > No virus found in this incoming message.
> > > Checked by AVG Free Edition.
> > > Version: 7.1.394 / Virus Database: 268.8.1/354 - Release Date: 6/1/2006
> > 


Mime
View raw message