Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@forrest.apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Date: Mon, 22 May 2006 16:49:10 +1000
From: David Crossley <crossley@apache.org>
To: dev@forrest.apache.org
Subject: Re: Proposed Change in Versioned Docs and PlugIn-Tabs
Message-ID: <20060522064910.GK452@igg.indexgeo.com.au>
References: <991367283.20060521105215@soethe.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <991367283.20060521105215@soethe.net>
User-Agent: Mutt/1.4.2.1i

Ferdinand Soethe wrote:
> 
> I'd like to fix or abandon the subtabs for Versioned Docs and PlugIn-Tabs
> because to this point they both don't work in a consistent way.

I understand your desire to address the sub-tabs problem.

Here are some of our issues.
http://issues.apache.org/jira/browse/FOR-607 
http://issues.apache.org/jira/browse/FOR-127
http://issues.apache.org/jira/browse/FOR-203
http://issues.apache.org/jira/browse/FOR-208
http://issues.apache.org/jira/browse/FOR-753

I have tried to tackle these problems on many
occasions but given up.

> To be more specific, the subtabs only show when the Versioned Docs-Tab
> is first selected, as soon as you choose a version they disappear
> and you have to return to the index page (or click Versioned Docs-tab)
> again to look at other versions.

To make things easier to see what is happening
i changed my site-author/skinconf.xml to
<color name="subtab-selected" value="#00ff00" ...
<color name="subtab-unselected" value="#ff0000" ...
This shows that sub-tabs are always shown as "selected".

localhost:8888/abs-menulinks
helps to show which tab that each menu item is
associated with.

URLs like this help a bit with debugging:
localhost:8888/pluginDocs/plugins_0_80/tab-index.html
then do view source.

That shows that "base-selected" etc. are not being
handled for subtabs, perhaps in:
webapp/skins/pelt/xslt/html/tab-to-menu.xsl

> To fix this we'd have to change the structure again and move all
> versioned docs in a proper subdirectory (docs\v_070) so that Forrest
> can associate the selected subtab with the the open file.

I gather that that will make the sub-tabs be shown
like the directory structure of pluginDocs.

However that is not the whole problem. There
are other issues about selected tabs. See above.

> That would be possible by putting in an extra day or so, moving all
> the docs, adjusting all the links and create regEx redirects in
> .htaccess.

We should not rely on .htaccess redirects.
It is becoming very cumbersome. But sure, if we need
to do that. 

> If we don't, I'll simply remove the subtabs and create a new version
> level in the versioned tabs menu structure.
> 
> Versioned Docs Tab menu:
> 
> Version 0.80
>   menu items
> Version 0.70
>   menu items
> Version 0.60
>   menu items

This is not good because then every page carries a very
hefty left-hand navigation panel. That generated code
would change for every page in all three versions when
we just add a new item in say 0.80 docs.

> It probably would be a good idea to fix the subtabs just to give
> people at least one fully working example of our tabs and menu system,
> so even though I hate the work I'd suggest the first.
> 
> wdyt?
> 
> To fix this for PlugIns I'l probably need some help in adjusting the
> pipelines. Anybody volunteering?

Sorry, i don't have time to help much with this whole
level2tabs issue. I would elect to ignore the problem
like we did last time.

-David