forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thors...@apache.org>
Subject RE: [Dispatcher] Common theme navigation contracts invalid
Date Tue, 02 May 2006 18:13:33 GMT
El mar, 02-05-2006 a las 07:11 +0800, Gav.... escribió:
> What Brian means is that in both common/nav-main.ft and
> common/nav-main-sub.ft there are <div>s declared both with id of 'tabs' . 

I need to look at it, but it makes sense what you say Gavin. Thanks for
clarifying.


> In pelt/nav-main-sub.ft the second-level tabs has an id of 'level2tabs'
> which is correct.
> 
> Having two <divs> with the same id is invalid markup - even in HTML 4.01
> Transitional. http://www.w3.org/TR/html4/struct/global.html#adef-id

Totally right.

> 
> So we need to change the common/nav-main-sub.ft to match the pelt version.

agree, will do so.

salu2

> 
> Gav...
> 
> > -----Original Message-----
> > From: Thorsten Scherler [mailto:thorsten@apache.org]
> > Sent: Monday, 1 May 2006 10:39 PM
> > To: dev@forrest.apache.org
> > Subject: Re: [Dispatcher] Common theme navigation contracts invalid
> > 
> > El dom, 30-04-2006 a las 19:50 -0500, Brian M Dube escribió:
> > > I looked for a relevant issue in JIRA, but I did not see one.
> > >
> > > There is a FIXME note [1] in pelt's nav-main-sub contract
> > 
> > You mean [I], right?
> > 
> > > to use the
> > > contract from common instead. Before that happens, the common contracts
> > > should be changed. Both common/html/nav-main.ft and
> > > common/html/nav-main-sub.ft add div tags with @id="tabs" and that won't
> > > validate.
> > 
> > What do you mean with "that won't validate"? With what?
> > 
> > [II] - The output format is html so I guess against xhtml-strict, right?
> > 
> > salu2
> > 
> > >
> > > Brian
> > >
> > > [1] FIXME - With a little css work, we should use the common contract
> > > and suppress this one (no need of level2tabs)
> > 
> > [I]
> > http://svn.apache.org/viewcvs.cgi/forrest/trunk/whiteboard/plugins/org.apa
> > che.forrest.themes.core/themes/pelt/html/nav-main-sub.ft?view=markup
> > 
> > [II]
> > http://svn.apache.org/viewcvs.cgi/forrest/trunk/whiteboard/plugins/org.apa
> > che.forrest.themes.core/themes/common/html/nav-main-sub.ft?view=markup
> > --
> > thorsten
> > 
> > 
> > 
> > "Together we stand, divided we fall!"
> > Hey you (Pink Floyd)
> > 
> > 
> > 
> > 
> > --
> > No virus found in this incoming message.
> > Checked by AVG Free Edition.
> > Version: 7.1.385 / Virus Database: 268.5.1/327 - Release Date: 28/04/2006
> 
> 
> 
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Mime
View raw message