Return-Path: Delivered-To: apmail-forrest-dev-archive@www.apache.org Received: (qmail 76077 invoked from network); 18 Apr 2006 08:38:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Apr 2006 08:38:05 -0000 Received: (qmail 54611 invoked by uid 500); 18 Apr 2006 08:38:04 -0000 Delivered-To: apmail-forrest-dev-archive@forrest.apache.org Received: (qmail 54556 invoked by uid 500); 18 Apr 2006 08:38:03 -0000 Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: dev@forrest.apache.org List-Id: Delivered-To: mailing list dev@forrest.apache.org Received: (qmail 54545 invoked by uid 99); 18 Apr 2006 08:38:03 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2006 01:38:03 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [212.23.3.140] (HELO pythagoras.zen.co.uk) (212.23.3.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Apr 2006 01:38:01 -0700 Received: from [82.69.78.226] (helo=[192.168.0.2]) by pythagoras.zen.co.uk with esmtp (Exim 4.30) id 1FVliN-0001EY-WC for dev@forrest.apache.org; Tue, 18 Apr 2006 08:37:40 +0000 Message-ID: <4444A549.5030406@apache.org> Date: Tue, 18 Apr 2006 09:37:29 +0100 From: Ross Gardler User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: en-us, en MIME-Version: 1.0 To: dev@forrest.apache.org Subject: Re: [ANN] odt plugin References: <1145228946.8514.9.camel@localhost.localdomain> <4442FFB1.6020600@apache.org> <1145259321.8276.3.camel@localhost.localdomain> <44441782.5030502@apache.org> <1145316916.8252.68.camel@localhost.localdomain> In-Reply-To: <1145316916.8252.68.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-Pythagoras-IP: [82.69.78.226] X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Thorsten Scherler wrote: > El lun, 17-04-2006 a las 23:32 +0100, Ross Gardler escribi=C3=B3: =2E.. >>No, I did not test, I just looked at the code. I do not have the time t= o=20 >>test it right now. I'm doing a review of the commit, that's all. >=20 >=20 > Thanks for the review (the code is from David Eisenberg) > http://svn.apache.org/viewcvs?rev=3D394229&view=3Drev >=20 > For anyone else, I reckon it takes 5 minutes to test. Just add to Even easier should be to cd into the plugin directoy and do "forrest=20 run". The idea of plugins is that their documentation provides examples=20 of all featues, these are also used fo testing when building. And there=20 is no longer any need to deploy the plugins unless you have made a chne=20 to the code since the last time they were deployed. However, we understand that sometimes it simply isn't possible to do=20 this, for example, when tavelling and only having access via a PDA. In=20 this case a code review is vey welcome. >>The transformation to XHTML creates embedded CSS styles in the final=20 >>output. Are these carried through to the final output? >=20 >=20 > http://localhost:8888/helloworld.xml >=20 > >
> Converted by odt_to_xhtml.xsl > > >
> >
> > <div class=3D"Standard">Hello World</div> > </section> > </body> > </document> I can't view the helloWold file at present. From the above it looks like = a really simple document. We need to ceate a more complete example, with = multiple sections, tables etc. This is a great stat though. > That is the outcome from the html-to-document.xsl (see above > {lm:transform.html.document}) transformation (last step in the odt > plugin).=20 > > The dispatcher ignores the <style/> and as well skins from a xdoc, the > answer is *no*, embedded CSS styles in *xdocs* are *not* carried throug= h > to the final output. OK, that's cool. > My question now is, do you think that we should suppress <style/> in th= e > {lm:transform.html.document}? At present there is no point in it being there, it is not used and the=20 user may be confused by it. Probably best to remove it. Howeve, in the longer term... this hits on exactly why I asked the=20 question in the first place. Some time ago I started some experimental=20 work on the OOo plugin. This would allow some styling in some elements=20 to pass through. Thus giving the user more felxibility in how they=20 describe the markup of a document. Daisy has an HTML cleaner which is highly configuable from external=20 files. We could extend this to make the whole thing much more=20 configurable on a per site basis. Ross