Return-Path: 
 <dev-return-23765-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 66150 invoked from network); 23 Apr 2006 12:55:17 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 23 Apr 2006 12:55:17 -0000
Received: (qmail 95109 invoked by uid 500); 23 Apr 2006 12:55:16 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 95077 invoked by uid 500); 23 Apr 2006 12:55:16 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
List-Post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
List-Id: <dev.forrest.apache.org>
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 95066 invoked by uid 99); 23 Apr 2006 12:55:16 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Apr 2006 05:55:16 -0700
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=MSGID_FROM_MTA_HEADER,UNPARSEABLE_RELAY
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Received: from [203.121.192.7] (HELO mail.e-wire.net.au) (203.121.192.7)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Apr 2006 05:55:15 -0700
Received: from developer (mail.e-wire.net.au [127.0.0.1])
	by mail.e-wire.net.au (8.13.1/8.13.1) with ESMTP id k3NCpIk7007031
	for <dev@forrest.apache.org>; Sun, 23 Apr 2006 20:51:19 +0800
Message-Id: <200604231251.k3NCpIk7007031@mail.e-wire.net.au>
Received: from 203-121-204-130.e-wire.net.au [203.121.204.130] for
 mail.e-wire.net.au
	(EHLO developer) via SMTP; Sun, 23 Apr 2006 20:51:19 +0800
Reply-To: <brightoncomputers@brightontown.com.au>
From: "Gav...." <brightoncomputers@brightontown.com.au>
To: <dev@forrest.apache.org>
Subject: RE: [jira] Commented: (FOR-639) define terminology for the various
 aspects of Dispatcher
Date: Sun, 23 Apr 2006 20:54:41 +0800
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook, Build 11.0.5510
Thread-Index: AcZmrC6qExvZV9fcSPuxDq5omc0ktwAKG48g
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2869
In-Reply-To: <20060423080456.GE15878@igg.indexgeo.com.au>
X-BitDefender-SpamStamp: 1.1.4
 049000040111ABAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAQ
X-BitDefender-Spam: No (0)
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N



> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Sunday, 23 April 2006 4:05 PM
> To: dev@forrest.apache.org
> Subject: Re: [jira] Commented: (FOR-639) define terminology for the
> various aspects of Dispatcher
> 
> > David Crossley commented on FOR-639:
> > ------------------------------------
> >
> > Thanks, patches applied. I will follow up separately regarding a few
> comments that will help with your patches.
> >
> > BTW, please keep the issues separate, e.g. this FOR-639 should be about
> the site-author/contents/xdocs/glossary.xml file and we should have
> separate issues for each particular enhancement to the Glossary Plugin
> itself.
> 
> Hi Gavin, a few notes i made when applying this patch.
> Just intended to be hints to ease the way for us all ...
> 
> -------
> You missed some files with this most recent patch,
> i.e. forgot to send the changes to site-author/.../glossary.xml
> and for the plugin's example glossary.xml to add your
> <definitions> elements. I added those myself, otherwise it
> broke the builds. To help with that, do
> cd $FORREST_HOME
> svn status
> ... that shows what files you changed.
> If you only have these changes, then do:svn diff > my-patch,txt
> Otherwise if there is other stuff that you don't want to add, then do:
> svn diff site-author
> whiteboard/plugins/org.apache.forrest.plugin.input.glossary > my-patch.txt

Cool, this looks way easier, I was diffing each file separately.

I did this on the voice plugin and all looks good apart from a couple of
things.

1. I renamed a file and it does not show up in the diff.
2. I added a file and that does not show up in the diff.

So should I for 

1. Do an SVN add for the new file and SVN delete for the old file
2. Do an SVN add.


Yes, I will read the Subversion docs when I get time later in the week, for
Now and for quickness please :)

Gav...

> 
> -------
> Your patch had full local filesystem path,
> i.e. D:/Apache2/forrest/whiteboard/...
> Better to start from $FORREST_HOME. The committer can easily
> cope with it, but extra work.
> 
> -------
> You removed the <p> wrapper on each "definition" so now
> subsequent definitions are jumbled together.
> 
> -David
> 
> 
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.385 / Virus Database: 268.4.5/322 - Release Date: 22/04/2006