forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gav...." <brightoncomput...@brightontown.com.au>
Subject RE: [jira] Commented: (FOR-639) define terminology for the various aspects of Dispatcher
Date Sun, 23 Apr 2006 12:54:41 GMT


> -----Original Message-----
> From: David Crossley [mailto:crossley@apache.org]
> Sent: Sunday, 23 April 2006 4:05 PM
> To: dev@forrest.apache.org
> Subject: Re: [jira] Commented: (FOR-639) define terminology for the
> various aspects of Dispatcher
> 
> > David Crossley commented on FOR-639:
> > ------------------------------------
> >
> > Thanks, patches applied. I will follow up separately regarding a few
> comments that will help with your patches.
> >
> > BTW, please keep the issues separate, e.g. this FOR-639 should be about
> the site-author/contents/xdocs/glossary.xml file and we should have
> separate issues for each particular enhancement to the Glossary Plugin
> itself.
> 
> Hi Gavin, a few notes i made when applying this patch.
> Just intended to be hints to ease the way for us all ...
> 
> -------
> You missed some files with this most recent patch,
> i.e. forgot to send the changes to site-author/.../glossary.xml
> and for the plugin's example glossary.xml to add your
> <definitions> elements. I added those myself, otherwise it
> broke the builds. To help with that, do
> cd $FORREST_HOME
> svn status
> ... that shows what files you changed.
> If you only have these changes, then do:svn diff > my-patch,txt
> Otherwise if there is other stuff that you don't want to add, then do:
> svn diff site-author
> whiteboard/plugins/org.apache.forrest.plugin.input.glossary > my-patch.txt

Cool, this looks way easier, I was diffing each file separately.

I did this on the voice plugin and all looks good apart from a couple of
things.

1. I renamed a file and it does not show up in the diff.
2. I added a file and that does not show up in the diff.

So should I for 

1. Do an SVN add for the new file and SVN delete for the old file
2. Do an SVN add.


Yes, I will read the Subversion docs when I get time later in the week, for
Now and for quickness please :)

Gav...

> 
> -------
> Your patch had full local filesystem path,
> i.e. D:/Apache2/forrest/whiteboard/...
> Better to start from $FORREST_HOME. The committer can easily
> cope with it, but extra work.
> 
> -------
> You removed the <p> wrapper on each "definition" so now
> subsequent definitions are jumbled together.
> 
> -David
> 
> 
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.385 / Virus Database: 268.4.5/322 - Release Date: 22/04/2006



Mime
View raw message