forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gav...." <brightoncomput...@brightontown.com.au>
Subject RE: Pelt Theme Dispatcher Observations
Date Tue, 04 Apr 2006 23:29:15 GMT


> -----Original Message-----
> From: Thorsten Scherler [mailto:thorsten.scherler@wyona.com]
> Sent: Wednesday, 29 March 2006 6:23 PM
> To: brightoncomputers@brightontown.com.au
> Cc: dev@forrest.apache.org
> Subject: Re: Pelt Theme Dispatcher Observations
> 
> El mar, 28-03-2006 a las 21:43 +0800, Gav.... escribió:
> > Hi all,
> >
> > Thought I would revert back to pelt theme from my pili theme to check
> how
> > this is doing. I have a few observations that I wanted to clarify
> before
> > creating issues for them and sorting them, maybe they already exist as
> > issues but I haven't found them as of yet.
> >
> > 1) - menus are not collapsable in IE or Firefox.
> >
> 
> In firefox it works for me (tried on site-author and pelt theme) in run
> and static. NOTE: the first time you need to click twice.

Have a look again at http://apache.minitutorials.com/ , click them as many
times as you like, the menu remains expanded. Like I said, doing a Forrest
run and it all works fine, this is from a static build & deploy using
forrestbot.

> 
> > 2) - Some images, notably spacer.gif and pdfdoc.gif are being looked
> for in
> > the /themes/images directory when they actually reside in /skin/images
> > directory and so are not being displayed.
> >
> > e.g of output source <img alt="spacer"
> src="themes/images/spacer.gif" />
> 
> No, not for me neither.
> themes/images/spacer.gif is in themes dir (and as well the pdfdoc.gif).
> The skin dir is copied even if not used since
> http://issues.apache.org/jira/browse/FOR-809
> 
> The dispatcher *should not* use the skin dir.

I will have to check this out, forrestbot build seems to put them in the
/skins/images/ directory.

> 
> 
> > 3) - Viewing in 800x600 mode on Windows the Search the site will
> overlap the
> > tabs if there are five or more tabs. [1]
> 
> Yes, I can see this on linux as well, can you fill a bug?

Will do.


> 
> >
> > 4) - Not important as such but anyway... Comments in the pelt.fv are
> being
> > converted into white space it seems in the code.
> 
> Yeah, somehow in general comments are not copied. Paul Bolger reported a
> similar issue
> http://issues.apache.org/jira/browse/FOR-834
> 
> You may want to add your following findings there. ;)

Done.

> 
> >
> > e.g -
> >
> > <forrest:property name="branding-css-links-input">
> >         <css url="common.css" media="screen" rel="alternate
> stylesheet"
> >           theme="common"/>
> >         <css url="leather-dev.css" media="screen" rel="alternate
> stylesheet"
> >
> >           theme="common"/>
> >         <css url="pelt.screen.css" media="screen" theme="Pelt"/>
> >         <!-- You can request request specific css, but beware that you
> need
> > to use the *.dispatcher.css extension!!!-->
> >         <!-- FIXME: that is not working ATM in forrest for subdir/bla
> needs
> > more testing -->
> >         <!--<css url="#{$getRequest}.dispatcher.css" media="screen"
> > theme="Pelt"/>-->
> >         <css url="pelt.print.css" media="print"/>
> >
> > Converts to :-
> >
> > <link href="themes/common.css" media="screen" rel="alternate
> stylesheet"
> > title="common" type="text/css" />
> >         <link href="themes/leather-dev.css" media="screen"
> rel="alternate
> > stylesheet" title="common" type="text/css" />
> >         <link href="themes/pelt.screen.css" media="screen"
> rel="stylesheet"
> > title="Pelt" type="text/css" />
> >
> >
> >
> >         <link href="themes/pelt.print.css" media="print"
> rel="stylesheet"
> > title="pelt.print.css" type="text/css" />
> >
> > 5) - Enabling use of the second instance of branding-breadcrumbs
> causes an
> > extra seemingly unwanted gap between the tabs section and the left
> > navigation/second breadcrumbs sections. This breaks up the continuity
> > between the tabs and the left navigation, is this by design or a bug?
> >
> 
> Can I see an example? I do not understand.

Sure, take another look at http://apache.minitutorials.com/ and it is there
:)

Notice the light blue line below the 'Home' Tab but above the Apache
Tutorials Menu Item. That is there because of the second instance of
breadcrumbs being enabled in the Pelt Theme. (Breadcrumbs are miniTutorials
> apache.miniTutorials)

With the second instance of breadcrumbs removed, this light blue line also
disappears, and the left hand nav menu once again 'touches' the rest of the
dark blue tabs area. If this is a feature let me know so I can safely ignore
it.

> 
> > Note that points 1 and 2 above work fine in a 'Forrest Run' byt when
> > statically built and deployed to a remote server is when the problems
> > Seem to occur.(?)
> 
> Hmm, you mean via forrestbot?

Yes.

> 
> >
> > [1] - For a couple of days, the effects can be seen at
> > http://apache.minitutorials.com

Still there. 

There are constant references to the use of these lists and there effect on
the archives, e.g re-naming of threads etc (oops) . Obviously my referencing
my site to show what I mean in these examples is good for me and good for
you guys to see, however they will be long gone by the time somebody comes
across these in the archives.

Hopefully, by the time my examples are gone, so will be the issues, so users
may not need to find them anyway, but still, on occasion it could be
annoying for someone to come across a link and find it no longer relevant.
This is true of all archived references of course, we can not control the
content changes of external links provided.

Does anyone have any thoughts on this, or is it a case of find the thread,
find the cure anyway.

Gav...




Mime
View raw message