forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Williams (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FOR-711) Cache results from the Locationmap
Date Fri, 10 Feb 2006 12:07:59 GMT
    [ http://issues.apache.org/jira/browse/FOR-711?page=comments#action_12365880 ] 

Tim Williams commented on FOR-711:
----------------------------------

See also http://issues.apache.org/jira/browse/FOR-732 

The XMLFileModule is the inspiration for the current LM caching.  It doesn't have to deal
with Source validity in the same way we do mainly because of the sub-LMs.  The XMLFileModule,
from what I can gather, was not a good choice to use for inspiration as it turns out anyway
since it's caching is done on its own instead of in the cocoon store.  I've been trying to
figure out how we might be able to put arbitrary data in the cocoon store but hadn't thought
of just aggregating the LMs and just implement cachaeblecomponent -- that's worth looking
into though as mentioned, we've still got the considerable sourcevalidity question.

The second approach you mentioned is easy enough but just when I had that basically implemented,
I started off on this cocoon store quest.  then the holidays, then travel...etc:(  

If we can't figure out how to store arbitrary data in the cocoon store (a mix of 1 and 2)
then I think we should look into 1.  I think the XMLFileModule is proving that storing data
outside the store is not a good idea because it is not "managed" and ultimately leads to OutOfMemory
exceptions -- though this is admittedly less likely in the LM. 

> Cache results from the Locationmap
> ----------------------------------
>
>          Key: FOR-711
>          URL: http://issues.apache.org/jira/browse/FOR-711
>      Project: Forrest
>         Type: Sub-task
>   Components: Locationmap
>     Reporter: Ross Gardler
>     Priority: Critical
>      Fix For: 0.8-dev

>
> Now that we are using the locationmap extensively it is showing up just how innefficient
it is. The problem is that for the majority of requests there are multiple reqeuests to the
locationmap. We can make things much faster (especially on the first page request) by caching
results in the locationmap.
> I think a simple cache will sufice, lets just provide a static hashmap using the hint
as a key and, of course, the location as the value.
> If we test all locationmaps and find no result we should record that tere is no result
in this hashmap. This will also be a good place to throw an exception so that Cocoon can better
report such errors (see FOR-701)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message