forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gavin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FOR-790) Head part is included as many times a contract is used
Date Mon, 16 Jan 2006 16:05:21 GMT
    [ http://issues.apache.org/jira/browse/FOR-790?page=comments#action_12362854 ] 

Gavin commented on FOR-790:
---------------------------

This can be avoided by using onFocus inline for Form values instead of calling the getBlank.js
script.

A generic e.g to adapt :-

<div><label for="username">Username</label> 
              <input name="username" type="text" id="username" value="Username" title="Enter
your Username here" onfocus="if(this.value == 'Username') this.value = ' ';"  />
            </div>

Not sure how many forms we have, not many I know of, so simple to do.

If however, it is prefered to keep the getBlank.js script, then a check to see if the getBlank.js
has already been inlcuded should do the trick.

Let me know which way is preferred and I'll create a patch.

Gav...

> Head part is included as many times a contract is used
> ------------------------------------------------------
>
>          Key: FOR-790
>          URL: http://issues.apache.org/jira/browse/FOR-790
>      Project: Forrest
>         Type: Improvement
>   Components: Dispatcher (aka views)
>     Versions: 0.8-dev
>     Reporter: Cyriaque Dupoirieux
>     Priority: Minor
>      Fix For: 0.8-dev

>
> Example :
> In the search contract - which is used twice in the pelt theme (as locations examples),
the getBlank.js file is, also, included twice.
>  <forrest:content>
>      <forrest:part xpath="/html/head">
>          <script type="text/javascript" language="javascript" src="{$root}themes/getBlank.js">&#160;</script>
>       </forrest:part>
> ...
> </forrest:content>
> gives :
>   <script language="javascript" src="../themes/getBlank.js" type="text/javascript">
</script>
>   <script language="javascript" src="../themes/getBlank.js" type="text/javascript">
</script>
> in the head part.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message