Return-Path: 
 <dev-return-21810-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 72424 invoked from network); 20 Dec 2005 13:12:57 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 20 Dec 2005 13:12:56 -0000
Received: (qmail 30735 invoked by uid 500); 20 Dec 2005 13:12:55 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 30697 invoked by uid 500); 20 Dec 2005 13:12:54 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
List-Post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
List-Id: <dev.forrest.apache.org>
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 30682 invoked by uid 99); 20 Dec 2005 13:12:54 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Dec 2005 05:12:52 -0800
Received: from ajax.apache.org (ajax.apache.org [127.0.0.1])
	by ajax.apache.org (Postfix) with ESMTP id F1B0FC9
	for <dev@forrest.apache.org>; Tue, 20 Dec 2005 14:12:30 +0100 (CET)
Message-ID: <69436500.1135084350843.JavaMail.jira@ajax.apache.org>
Date: Tue, 20 Dec 2005 14:12:30 +0100 (CET)
From: "Johannes Schaefer (JIRA)" <jira@apache.org>
To: dev@forrest.apache.org
Subject: [jira] Commented: (FOR-769) tables don't support row/colspan
In-Reply-To: <34382698.1135083810432.JavaMail.jira@ajax.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

    [ http://issues.apache.org/jira/browse/FOR-769?page=comments#action_12360915 ] 

Johannes Schaefer commented on FOR-769:
---------------------------------------

I implemented this, but have a question before comitting.

I would like to avoid code duplication as is the case in the match for <entry> in sdocbook2document.xsl from the plugin, see the code snippet below. The same template exists for <entry> with mode="thead" the only difference beeing <th> instead of <td>. I look for an option to avoid duplication and see the following:
1. use a named template and call this
2. match <entry> without node and check name(..) to insert <td> or <th>
3. pass "td" or "th" as a parameter to the template
What would be the best way?
Johannes

      <xsl:template match="entry">
            <td>
              <!-- this code is duplicated in template match="entry" mode="thead" -->
              <xsl:if test="@morerows">
                <xsl:attribute name="rowspan">
                  <xsl:value-of select="number(@morerows)+1"/>
                </xsl:attribute>
              </xsl:if>
              <xsl:if test="@namest and @nameend">
                <xsl:attribute name="colspan">

                <xsl:variable name="start">
                  <xsl:call-template name="colspec.index">
                    <xsl:with-param name="olist" select="ancestor::tgroup/colspec"/>
                    <xsl:with-param name="colname" select="@namest"/>
                  </xsl:call-template>
                </xsl:variable>
                <xsl:variable name="end">
                  <xsl:call-template name="colspec.index">
                    <xsl:with-param name="olist" select="ancestor::tgroup/colspec"/>
                    <xsl:with-param name="colname" select="@nameend"/>
                  </xsl:call-template>
                </xsl:variable>

                  <xsl:value-of select="number($end)-number($start)+1"/>
                </xsl:attribute>
              </xsl:if>
              <xsl:apply-templates/>
              <!-- end code duplication -->
            </td>
      </xsl:template>


> tables don't support row/colspan
> --------------------------------
>
>          Key: FOR-769
>          URL: http://issues.apache.org/jira/browse/FOR-769
>      Project: Forrest
>         Type: Bug
>   Components: Plugin: Simplified Docbook
>     Versions: 0.7
>  Environment: all
>     Reporter: Johannes Schaefer
>     Assignee: Johannes Schaefer
>  Attachments: index.xml
>
> the plugin should support the sDocBook attributes to span rows and columns in a table; see attached file and below
> <table>
> ...
>   <colspec  colname='c1'/>
>   <colspec  colname='c2'/>
>   <colspec  colname='c3'/>
>   <colspec colnum='5' colname='c5'/>
> ...
>   <entry morerows='1>
>   <entry namest="c2" nameend="c5">span to c5</entry>
>   <entry namest="c2" nameend="c3" morerows='1'>
> </table>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira