Return-Path: 
 <dev-return-21823-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 57044 invoked from network); 20 Dec 2005 20:34:14 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 20 Dec 2005 20:34:14 -0000
Received: (qmail 54181 invoked by uid 500); 20 Dec 2005 20:34:01 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 53694 invoked by uid 500); 20 Dec 2005 20:33:59 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
List-Post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
List-Id: <dev.forrest.apache.org>
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 53616 invoked by uid 99); 20 Dec 2005 20:33:58 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [192.87.106.226] (HELO ajax.apache.org) (192.87.106.226)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Dec 2005 12:33:56 -0800
Received: from ajax.apache.org (ajax.apache.org [127.0.0.1])
	by ajax.apache.org (Postfix) with ESMTP id 44AC6DE
	for <dev@forrest.apache.org>; Tue, 20 Dec 2005 21:33:32 +0100 (CET)
Message-ID: <47541540.1135110812280.JavaMail.jira@ajax.apache.org>
Date: Tue, 20 Dec 2005 21:33:32 +0100 (CET)
From: "helena (JIRA)" <jira@apache.org>
To: dev@forrest.apache.org
Subject: [jira] Commented: (FOR-506) Do not hard-code site-visible message
 strings in skin files
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

    [ http://issues.apache.org/jira/browse/FOR-506?page=comments#action_12360964 ] 

helena commented on FOR-506:
----------------------------

Excuse my initial comment - slopy wording.
In the  patchI18n.diff file, the nesting is not clear:
 <map:generator name="text2xml" logger="sitemap.generator.textgenerator"
                      src="org.apache.cocoon.generation.TextGenerator">
        <parameter name="localizable" value="true"/>
      </map:generator>        
      </map:generator>
     </map:generators>
     <map:transformers default="xslt">
     <parameter name="recovery" value="true"/>
     <parameter name="localizable" value="true"/>
    </map:transformer> 

  <map:transformer name="i18n" src="org.apache.cocoon.transformation.I18nTransformer">
    <catalogues default="common">
      <catalogue id="common" name="CommonMessages" location="skins/common/messages"/>
    </catalogues>
    <cache-at-startup>true</cache-at-startup>
  </map:transformer>

</map:transformers>
 
     <map:readers default="resource">
       <map:reader name="resource" src="org.apache.cocoon.reading.ResourceReader"/>
             </map:transform>
           </map:otherwise>
         </map:select>
        <map:transform type="i18n">
          <map:parameter name="locale" value="{request:locale}"/>
		      <!--<map:parameter name="locale" value="es-ES"/>-->
	      </map:transform>
       <map:serialize/>
     </map:resource>

> Do not hard-code site-visible message strings in skin files
> -----------------------------------------------------------
>
>          Key: FOR-506
>          URL: http://issues.apache.org/jira/browse/FOR-506
>      Project: Forrest
>         Type: Improvement
>   Components: Skins (general issues)
>     Versions: 0.7
>  Environment: N/A
>     Reporter: Pedro I. Sanchez
>     Assignee: Thorsten Scherler
>     Priority: Minor
>  Attachments: frenchMessages.diff, newFrenchMessages.diff, patchI18n.diff
>
> Text strings like "Copyright", "Published", and "Search" are hardcoded into skin files like site2xhtml.xsl. When creating web sites in languages other than English the web developer is forced to create local versions of these skin files with the appropriated translations.
> Instead, the DTD for the skinconf.xml should be improved to allow these translations to be specified in this file. This would make Forrest much easier to use.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira