forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "helena (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FOR-506) Do not hard-code site-visible message strings in skin files
Date Tue, 20 Dec 2005 20:33:32 GMT
    [ http://issues.apache.org/jira/browse/FOR-506?page=comments#action_12360964 ] 

helena commented on FOR-506:
----------------------------

Excuse my initial comment - slopy wording.
In the  patchI18n.diff file, the nesting is not clear:
 <map:generator name="text2xml" logger="sitemap.generator.textgenerator"
                      src="org.apache.cocoon.generation.TextGenerator">
        <parameter name="localizable" value="true"/>
      </map:generator>        
      </map:generator>
     </map:generators>
     <map:transformers default="xslt">
     <parameter name="recovery" value="true"/>
     <parameter name="localizable" value="true"/>
    </map:transformer> 

  <map:transformer name="i18n" src="org.apache.cocoon.transformation.I18nTransformer">
    <catalogues default="common">
      <catalogue id="common" name="CommonMessages" location="skins/common/messages"/>
    </catalogues>
    <cache-at-startup>true</cache-at-startup>
  </map:transformer>

</map:transformers>
 
     <map:readers default="resource">
       <map:reader name="resource" src="org.apache.cocoon.reading.ResourceReader"/>
             </map:transform>
           </map:otherwise>
         </map:select>
        <map:transform type="i18n">
          <map:parameter name="locale" value="{request:locale}"/>
		      <!--<map:parameter name="locale" value="es-ES"/>-->
	      </map:transform>
       <map:serialize/>
     </map:resource>

> Do not hard-code site-visible message strings in skin files
> -----------------------------------------------------------
>
>          Key: FOR-506
>          URL: http://issues.apache.org/jira/browse/FOR-506
>      Project: Forrest
>         Type: Improvement
>   Components: Skins (general issues)
>     Versions: 0.7
>  Environment: N/A
>     Reporter: Pedro I. Sanchez
>     Assignee: Thorsten Scherler
>     Priority: Minor
>  Attachments: frenchMessages.diff, newFrenchMessages.diff, patchI18n.diff
>
> Text strings like "Copyright", "Published", and "Search" are hardcoded into skin files
like site2xhtml.xsl. When creating web sites in languages other than English the web developer
is forced to create local versions of these skin files with the appropriated translations.
> Instead, the DTD for the skinconf.xml should be improved to allow these translations
to be specified in this file. This would make Forrest much easier to use.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message