forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ross Gardler <rgard...@apache.org>
Subject Re: Forrest Proxy Settings
Date Mon, 12 Dec 2005 23:32:15 GMT
Gav.... wrote:
> The current init-proxy target says:-
> 
>   <target name="init-proxy" if="proxy.host">
>    <property name="proxy.port" value="80"/>
>    <echo>Using proxy : ${proxy.host}:${proxy.port}</echo>
>    <setproxy proxyhost="${proxy.host}" proxyport="${proxy.port}"/>
>   </target>
> 
> Would changing it to this be enough or is there more to do :-
> 
>   <target name="init-proxy" if="proxy.host">
>    <property name="proxy.port" value="80"/>
>    <property name="proxy.user" value=""/>
>    <property name="proxy.password" value=""/>
>    <echo>Using proxy : ${proxy.host}:${proxy.port}</echo>
>    <echo>Using Username : ${proxy.user}:${proxy.password}</echo>
>    <setproxy proxyhost="${proxy.host}" proxyport="${proxy.port}"/>
>    <setproxy proxyuser="${proxy.user}" proxypassword="${proxy.password}"/>
>   </target>
> 
> After which , proxy.user and proxy.password can then be set in project 
> properties.

I don't know if it works or not because I'm not behind an authenticating 
  proxy so can't easily test. I do have a few observations though:

I don't think there would be two setproxy tasks and it is best not to 
echo the password to screen (people looking over shoulders, logging 
scripts etc.)

Also I'm not sure of the default behaviour if no user/password 
combination is provided. Would need to check the Ant manual for that, it 
may be necessary to put a guard on there if they are not set.

The defaults should really be set in defaults.forrest.properties - not 
in the forrest.build.xml (this goes for proxy.port as well).

Ross

Mime
View raw message