forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Crossley <cross...@apache.org>
Subject Re: svn commit: r306554 - in /forrest/branches/forrest_07_branch/main/webapp: resources/stylesheets/html2document.xsl skins/common/xslt/html/document2html.xsl skins/pelt/xslt/html/document2html.xsl
Date Fri, 14 Oct 2005 03:08:39 GMT
Ross Gardler wrote:
> David Crossley wrote:
> >There is something wrong here. The Apache XML project
> >uses forrest_07_branch and they are reporting that the
> >"Note" elements are not rendered anymore. I confirmed
> >that by going back to just before this revision. Also
> >everything is okay using 0.8-dev to build their site.
> >So i presume that something was missed during r306554.
> >I have no idea what sorry, becuase i don't understand
> >these changes.
> 
> in skins/common/xslt/html/document2html.xsl:
> 
> >>  <xsl:template match="note | warning | fixme">
> >>    <xsl:apply-templates select="@id"/>
> >>-    <div class="frame {local-name()}">
> >>+    <div class="{local-name()}">
> >>      <div class="label">
> >>        <xsl:choose>
> 
> The frame class has been removed, I'd be tempted to say this will be the 
> problem, but...
> 
> What confuses me is that the commit message said these were copied over 
> from 0.8-dev so if 0.8-dev is working why isn't 0.7?
> 
> I also note that the zone test site looks just fine.
> 
> Perhaps the frame class was needed in 0.7 but some change in the CSS 
> means it is no longer needed in 0.8-dev.
> 
> Maybe try adding the frame class back in and seeing if that works.

Found it. There were earlier changes to basic.css in trunk
which had not been applied to the branch. Done now.

-David

Mime
View raw message