forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thors...@apache.org>
Subject Hardcoded values in forrest.xconf
Date Wed, 07 Sep 2005 08:40:36 GMT
On Wed, 2005-09-07 at 00:27 -0700, Diwaker Gupta wrote:
> Diff to make the internal plugin work
> -------------------------------------
> 
> Index: webapp/WEB-INF/xconf/forrest-core.xconf
> ===================================================================
> --- webapp/WEB-INF/xconf/forrest-core.xconf     (revision 279235)
> +++ webapp/WEB-INF/xconf/forrest-core.xconf     (working copy)
> @@ -130,8 +130,10 @@
> 
> <whiteboard-plugins-src>@forrest.home@/whiteboard/plugins</whiteboard-plugins-src>
>          <plugins>@forrest.home@/build/plugins</plugins>
>          <locationmap>@context.home@/locationmap.xml</locationmap>
> -        
> <view-internal>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.view</view-internal>
> -        
> <view-themes>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.view/resources/views</view-themes>
> +        
> <view-internal>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.xhtml2</view-internal>
> +        
> <view-themes>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.xhtml2/resources/views</view-themes>
> +        
> <!--<view-internal>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.view</view-internal>-->
> +        
> <!--<view-themes>@forrest.home@/build/plugins/org.apache.forrest.plugin.internal.view/resources/views</view-themes>-->
>          <theme-ext>.fv</theme-ext>
>          <theme>default</theme>
>        </values>
> 

I did that hardcoding. Why not just add a new property to the
forrest.properties? 

So instead of hardcoding it again, why not using something like:
<view-internal>@forrest.home@/build/plugins/@project.viewPlugin@</view-internal>

salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Mime
View raw message