forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Diwaker Gupta <diwa...@apache.org>
Subject Re: whitespace cleanup test
Date Wed, 24 Aug 2005 07:13:27 GMT
Can we use something like Jalopy (http://jalopy.sf.net) to periodically clean 
up all the Java files? It doesn't need to be a Forrest. One of us can run it 
through once in a while (I'm happy to volunteer). I've used Jalopy in the 
past -- it works really well, its highly customizable, and has excellent Ant 
integration.

On Tuesday 23 August 2005 9:15 pm, David Crossley wrote:
> Tim Williams wrote:
> > Can someone with whitespace knowledge see if this actually cleaned up
> > the whitespace issues in this file properly?
>
> It was not a good test, because this file did not have a mixture
> of tabs and space indenting, like many of our files do.
>
> Also this file was in good shape - just some some trailing whitespace,
> which your editor did properly clean up.
>
> Other files (e.g. many of our stylesheets) have a mess of inconsistent
> indenting. That is why we cannot just do a simple "replace all tabs
> with spaces" - those files would still have bad indenting.
>
> I think that we need to set up a test directory which has
> examples of bad whitespace. I will go and start that.
>
> >  I think my text editor
> > has "wanted to do the right thing" all along but I've forced it into
> > just doing functional diffs instead. I'm fairly confident that no one
> > else is touching the files I am so if this works, I could go ahead and
> > fix them all fairly quickly.
> > --tim
> >
> > > Author: twilliams
> > > Date: Tue Aug 23 19:41:53 2005
> > > New Revision: 239511
> > >
> > > URL: http://svn.apache.org/viewcvs?rev=239511&view=rev
> > > Log:
> > > whitespace cleanup test
> > >
> > > Modified:
> > >    
> > > forrest/trunk/main/java/org/apache/forrest/locationmap/LocationMapModul
> > >e.java
> > >
> > > Modified:
> > > forrest/trunk/main/java/org/apache/forrest/locationmap/LocationMapModul
> > >e.java URL:
> > > http://svn.apache.org/viewcvs/forrest/trunk/main/java/org/apache/forres
> > >t/locationmap/LocationMapModule.java?rev=239511&r1=239510&r2=239511&view
> > >=diff
> > > =======================================================================
> > >======= ---
> > > forrest/trunk/main/java/org/apache/forrest/locationmap/LocationMapModul
> > >e.java (original) +++
> > > forrest/trunk/main/java/org/apache/forrest/locationmap/LocationMapModul
> > >e.java Tue Aug 23 19:41:53 2005 @@ -1,13 +1,13 @@
> > >  /*
> > >   * Copyright 1999-2004 The Apache Software Foundation or its
> > > licensors, * as applicable.
> > > - *
> > > + *
>
> Argh, it seems that our program that inserted the license headers
> in java files that were missing the license, adds trailing whitespace
> after the comment marker on "blank" lines. So many of our java files
> will have this problem.
>
> -David

-- 
Web/Blog/Gallery: http://floatingsun.net

Mime
View raw message