forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Crossley <cross...@apache.org>
Subject Re: [Vote] deprecated seed (was Re: svn commit: r231130)
Date Wed, 10 Aug 2005 03:03:32 GMT
Thorsten Scherler wrote:
> 
> http://issues.apache.org/jira/browse/FOR-253
> 
> There are some more mails around that topic in the archive. 
> 
> Here my +1 to deprecated the "seed" target and use "seed-sample"
> instead.

It would be better to have a proposal first, because
now we need to discuss implementation details inside
a vote thread. See next topic "when to call a vote".

Anyway, +1 from me.

However, there are some qualifications.

We need consistent names. I notice that some of us
use xml style naming conventions while others use
java style, e.g. seed-sample, seedBusiness

We need to revisit all the 0.8 docs and fix the
discussion of the old 'forrest seed'. Just add a note
to FOR-253 for this.

Wouldn't it be better to also 'svn move' the content
of main/fresh-site/ to main/template-sites/sample/

> If vote pass I will apply:
> Index: main/targets/seed.xml

But please don't mix whitespace changes too. That made
it a bit hard to follow (unnecessary change to <copy>).

-David

> ===================================================================
> --- main/targets/seed.xml       (revision 231130)
> +++ main/targets/seed.xml       (working copy)
> @@ -33,9 +33,14 @@
>    <!-- ===============================================================
>          Copies a template structure over to your project dir.
>         ===============================================================
> -->
> -  <target name="seed" depends="ensure-nocontent"
> -    description="deprecated - use 'seed-sample' instead * Seeds a
> directory with a template project doc structure">
> -     <copy todir="${project.home}" overwrite="false">
> +  <target name="seed"
> +    description="*deprecated - use 'seed-sample' instead*">
> +     <antcall target="seed-sample"/>
> +  </target>
> +
> +  <target name="seed-sample" depends="ensure-nocontent"
> +    description="* Seeds a directory with a template project doc
> structure">
> +    <copy todir="${project.home}" overwrite="false">
>          <fileset dir="${forrest.core}/fresh-site"/>
>       </copy>
>       <loadfile  property="template-project-created-message"
> srcFile="${forrest.core}/var/template-project-created-message-sample.txt">@@ -44,10
+49,6 @@
>      <echo>${template-project-created-message}</echo>
>    </target>
> 
> -  <target name="seed-sample" description="* Seeds a directory with a
> template project doc structure">
> -    <antcall target="seed"/>
> -  </target>
> -
>    <target name="seed-basic" depends="ensure-nocontent"
>      description="* Seeds a basic example (1 file) and structure">
>       <copy todir="${project.home}" overwrite="false">
> -- 
> thorsten
> 
> "Together we stand, divided we fall!" 
> Hey you (Pink Floyd)

Mime
View raw message