forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Manuel Mall (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FOR-592) Pelt skin not HTML 4.01 compliant
Date Mon, 01 Aug 2005 14:21:39 GMT
    [ http://issues.apache.org/jira/browse/FOR-592?page=comments#action_12317335 ] 

Manuel Mall commented on FOR-592:
---------------------------------

I tried to fix it but are stuck. Changing:
    <input type="submit" value="Search" name="Search" i18n:attr="value"/>
to
    <input type="submit" value="Search" name="Search"/>
didn't seem to break anything and gets rid of one of the validation failures.

But how does one change this?:
  <xsl:template name="last-published">
    <script type="text/javascript"><![CDATA[<!--
document.write("]]><i18n:text >Last Published:</i18n:text><![CDATA[ " +
document.lastModified);
//  -->]]></script>
  </xsl:template>
such that the final output is:
   document.write("<text>Last Published:<\/text> " + document.lastModified);

> Pelt skin not HTML 4.01 compliant
> ---------------------------------
>
>          Key: FOR-592
>          URL: http://issues.apache.org/jira/browse/FOR-592
>      Project: Forrest
>         Type: Bug
>   Components: Skins (general issues)
>     Versions: 0.7, 0.8-dev
>     Reporter: Manuel Mall
>      Fix For: 0.8-dev

>
> Just go to the Forrest home page and click the HTML 4.01 Compliance button. The page
doesn't validate. Other sites, e.g. Apache FOP, created with the same skin have the same problem.
One issue I could identify is that in the site2xhtml.xsl there are tags like: 
>     <input type="submit" value="Search" name="Search" i18n:attr="value"/>. 
> The 'i18n:attr="value"' bit creates a non HTML 4.01 compliant attribute. Other problems
are related to Javascript not being escaped correctly, e.g.  
>      document.write("<text>Last Published:</text> " + document.lastModified);
> should be written as
>    document.write("<text>Last Published:<\/text> " + document.lastModified);
> I assume a requirement of being allowed to put the W3C HTML 4.01 Compliant logo on the
site is that the pages correctly validate. Pages based on this skin don't validate but do
carry the logo. Sounds like a problem to me.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message