Return-Path: 
 <dev-return-18163-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 22538 invoked from network); 29 Jul 2005 14:51:52 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 29 Jul 2005 14:51:52 -0000
Received: (qmail 35586 invoked by uid 500); 29 Jul 2005 14:51:51 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 35544 invoked by uid 500); 29 Jul 2005 14:51:51 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
List-Post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
List-Id: <dev.forrest.apache.org>
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 35521 invoked by uid 99); 29 Jul 2005 14:51:51 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jul 2005 07:51:50 -0700
X-ASF-Spam-Status: No, hits=1.2 required=10.0
	tests=PRIORITY_NO_NAME,SPF_HELO_PASS
X-Spam-Check-By: apache.org
Received-SPF: neutral (asf.osuosl.org: local policy)
Received: from [80.67.18.15] (HELO smtprelay03.ispgateway.de) (80.67.18.15)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 29 Jul 2005 07:51:42 -0700
Received: (qmail 1229 invoked from network); 29 Jul 2005 14:51:46 -0000
Received: from unknown (HELO localhost) (305514@[217.251.131.71])
          (envelope-sender <ferdinand@apache.org>)
          by smtprelay03.ispgateway.de (qmail-ldap-1.03) with SMTP
          for <dev@forrest.apache.org>; 29 Jul 2005 14:51:46 -0000
Date: Fri, 29 Jul 2005 16:51:46 +0200
From: Ferdinand Soethe <ferdinand@apache.org>
Reply-To: Ferdinand Soethe <ferdinand@apache.org>
X-Priority: 3 (Normal)
Message-ID: <233163608.20050729165146@soethe.net>
To: dev@forrest.apache.org
Subject: Re: Error transforming Table IDs
In-Reply-To: <42EA283D.3010608@apache.org>
References: <1478439735.20050725065637@soethe.net>
 <1256974557.20050725154442@soethe.net>
 <1122299671.10714.13.camel@localhost.localdomain>
 <968807665.20050729144721@soethe.net> <42EA283D.3010608@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N

OK, I think I found the culprit for the strange behavior with
IMG-elements.

The Problem:

After fixing the problem of id-attributes not being passed
through to the final HTML I notices a strange behaviour with
IMG-elements:

- If an IMG-element had no id-attribute everything worked fine. IMG
  was processed as expected.
- If it had an id-attribute however strange things happended, the
  IMG-element was renderered like this

  <img alt="Icon"><a name="icon"></a> which obviously made it pretty
  useless.

Analysis:

Going down the pipeline I found the culprit in pelts document2html
where img is processed as part of this default template:

1  <xsl:template match="node()|@*" priority="-1">
2    <xsl:copy>
3      <xsl:apply-templates select="@*"/>
4      <xsl:apply-templates/>
5    </xsl:copy>
6  </xsl:template>

Debugging this I found line 3 starting to copy the IMG-element then
trying to execute the following template

 <!-- Generate a <a name="..."> tag for an @id -->
  <xsl:template match="@id">
    <xsl:if test="normalize-space(.)!=''">
      <a name="{.}"/>
    </xsl:if>
  </xsl:template>

which tries to insert a a-element right into our open img-element,
triggering an error and aborting the processing (which explains the
strange result).

Attempted Solution:

1  <xsl:template match="node()|@*" priority="-1">
     <!-- id processing will create its own a-element so processing has to
          happen outside the copied element
     -->
2   <xsl:apply-templates select="@id"/>
3    <xsl:copy>
4      <xsl:apply-templates select="@* and ???"/>
5       <xsl:attribute name="id">{id}</xsl:attribute>
       <xsl:apply-templates/>
     </xsl:copy>
   </xsl:template>

Line 2 will only process ids and insert the a-element before the
       img-tag as usual (question: does it make sense to have this
       id-processing here AND in several templates that I saw in
       common? That seems to invite redundant processing?)

Line 4 should now exclude @id but I'm not sure how to express that in
       X-Path if I want to process all attributes but id? Can someone
       pls help?

Line 5 inserts the unprocessed id-attribute for use in css-styling.

So wdyt?


--
Ferdinand Soethe