forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Williams (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FOR-554) Error for missing documents is confusing
Date Mon, 27 Jun 2005 13:52:57 GMT
    [ http://issues.apache.org/jira/browse/FOR-554?page=comments#action_12314534 ] 

Tim Williams commented on FOR-554:
----------------------------------

With further testing it seems that this patch causes a new problem.  It's going to take me
some time to figure this one out I think.  It works well when the target of a matching locationmap
entry is not found (i.e. it reports a file not found error).  The problem is when there is
no match at all in locationmap (i know, should have tested that case sooner) the generator
apparently tries to load with "C:\src\apache-forrest-lm\main\webapp".  This seems very similar
to the problem we had in SourceExistsSelector before in that it's resolving to an empty string
and I can only assume that an empty string in cocoon-land somehow equates to the sitemap containing
directory.  

Anyway, this is a long way of saying that I think the patch above does make sense -- as in
it needed to be done -- but it doesn't completely resolve the issue.

--tim  

> Error for missing documents is confusing
> ----------------------------------------
>
>          Key: FOR-554
>          URL: http://issues.apache.org/jira/browse/FOR-554
>      Project: Forrest
>         Type: Bug
>   Components: Locationmap
>     Versions: 0.8-dev
>     Reporter: Tim Williams
>     Assignee: Ross Gardler
>  Attachments: for-554.patch
>
> Described at the top of this discussion:
> http://marc.theaimsgroup.com/?l=forrest-dev&m=111961459500409&w=2
> When tabs, site, and resources were made resolvable through locationmap, everything was
placed in a "when-exists" test.  That means instead of getting a meaningful error like "The
system cannot find the specified file." it goes straight to the transformer code and fails
because no generator exists.  An "otherwise" should have been used so that it will fail back
at the generator section and report a "good" error.
> --tim

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message