forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ross Gardler <rgard...@apache.org>
Subject Re: [jira] Commented: (FOR-506) Do not hard-code site-visible message strings in skin files
Date Sun, 05 Jun 2005 12:41:55 GMT
Pedro I. Sanchez wrote:
> On Sun, 2005-05-06 at 04:19 +0200, Thorsten Scherler wrote:
> 
>>On Sat, 2005-06-04 at 20:55 -0400, Pedro I. Sanchez wrote:

...

>>Nice, can you prepare a patch and add it to this issue? I will apply it
>>then, thx. I reckon there are more to come. ;-)
>>
> 
> Index: webapp/skins/common/messages/CommonMessages_es.xml

Pedro, thanks for your patch.

Just a point to note, in future it is best to attach a patch to a
related issue, that way it doesn't get lost in the archives. In this
case Thorsten is on the ball so it doesn't matter, but imagine he had
been called away for work. An email is easy to forget about, a patch isn't.

Once again, thanks for highlighting this need, and for your contribution.

Ross


Mime
View raw message