forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Juan Jose Pablos (JIRA)" <j...@apache.org>
Subject [jira] Commented: (FOR-514) Do not limit status.xml contexts in project info plugin
Date Mon, 06 Jun 2005 09:09:40 GMT
    [ http://issues.apache.org/jira/browse/FOR-514?page=comments#action_12312723 ] 

Juan Jose Pablos commented on FOR-514:
--------------------------------------

In order to get this validated with actuall dtd, we need to change:

1) remove the contexts entity:

===================================================================
--- common-elems-v10.mod        (revisiĆ³n: 180256)
+++ common-elems-v10.mod        (copia de trabajo)
@@ -47,7 +47,6 @@
 <!-- =============================================================== -->
 
 <!ENTITY % types "add|remove|update|fix">
-<!ENTITY % contexts "build|docs|code|admin|design">
 <!ENTITY % importances "high|medium|low">
 

2) use a IDREF instead of an entity:

 <!-- =============================================================== -->
@@ -61,7 +60,7 @@
 <!ATTLIST action %common.att;
           dev  IDREF  #REQUIRED
           type (%types;)  #IMPLIED
-          context (%contexts;) #IMPLIED
+          context  IDREF  #REQUIRED
           importance (%importances;) "medium"
           due-to CDATA #IMPLIED
           due-to-email CDATA #IMPLIED

3) create <context id="docs" title="Changes to the documentation" > element on the status
file.

But: This seem to collapse with the dev IDREF. We can live with it ( It is unusual that a
person has the same id than a context)

Please let me know  what do you think, so I can apply this patch.


> Do not limit status.xml contexts in project info plugin
> -------------------------------------------------------
>
>          Key: FOR-514
>          URL: http://issues.apache.org/jira/browse/FOR-514
>      Project: Forrest
>         Type: Improvement
>   Components: Plugin: projectInfo
>     Reporter: Ross Gardler
>     Priority: Minor
>  Attachments: 514-patch.txt
>
> (This comment brought over from FOR-487)
> This improvement of changes page is nice.
> I have my own version based on xsl:key definition in order to be able to simply manage
as many contexts as you can define (My Dtd is not limited to "build|docs|code|admin|design".
> The advantage - on my opinion - is that my own contexts are very various and not developpement
oriented nor language dependant.
> here a short example - using releaseNote... :
>         http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html
> The following code replace the 5 blocks <xsl:if test="action[@context='build']">
:
>    <title>Version <xsl:value-of select="@version"/> (<xsl:value-of select="@date"/>)</title>
> + <xsl:for-each select="action[generate-id()=generate-id(key('contextes',concat(../@version,
'_', @context)))]">
> + <xsl:sort select="@context"/>
> + <section>
> + <title><xsl:value-of select="@context"/></title>
> + <ul>
> + <xsl:apply-templates select="key('contextes',concat(../@version, '_', @context)
)">
> + <xsl:sort select="@type"/>
> + </xsl:apply-templates>
> + </ul>
> + </section>
> + </xsl:for-each>
> Hope you'll like the idea...
> Regards,
> Cyriaque,

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message